New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jbuilder #565
Conversation
IIUC, this is a reboot of #541 using jbuilder ? Interesting. Can you give a quick rundown of what us non-janstreetians need to know after this transition (from a practical point of view) ? |
The janestreetness does not really matter here ;) You will be able to start using jbuilder with
It builds fast and support incremental build. which works well for development
Using jbuilder makes managing multiple opam package for js_of_ocaml very easy.
Still need more work to fully replace the current build system.
It is also super convenient to tests multiple ocaml version / opam switch at once.
Note this PR also adds a dependency on ocaml-migrate-parsetree and ppx_tools_versioned. |
That's the summary I was hoping for. Thanks! This looks really nice. |
c62375e
to
90504b2
Compare
fd54db6
to
844b742
Compare
Misc: update location of runtime
yay @hhugo 💯 🎖️ |
@hhugo I don't understand how ppx tests are run, if they are run at all. Did you ported that ? |
Tests have not been fully ported yet. |
) | ||
|
||
package "log" ( | ||
requires = "js_of_ocaml-ppx.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
js_of_ocaml-ppx.log
doesn't exist. Require js_of_ocaml-lwt.logger
, or remove js_of_ocaml.log
altogether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a typo. It should be js_of_ocaml-lwt.log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed a fix
This is a work in progress, resurrection of #565,
making use of jbuilder, ocaml-migrate-parsetree, ppx_tools_versionned.
Js_of_ocaml is now split as follow
Async and ppx_driver support have disappeared and are/will be maintained by Janestreet (cc @diml)
TODO
WAITING
https://github.com/hhugo/ppx_tools_versioned.git
NEXT
Should address the following issues
fix #265
fix #360
fix #566
fix #545
fix #543
fix #523