Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translate attribute #281

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Add translate attribute #281

merged 2 commits into from
Jan 21, 2021

Conversation

jchavarri
Copy link
Contributor

@jchavarri
Copy link
Contributor Author

@Drup I added some tests in 5c0e796 for good measure, but happy to remove that commit if it's not really needed.

@Drup
Copy link
Member

Drup commented Jan 21, 2021

Looks perfect! 👍

@Drup Drup merged commit 58e26c1 into ocsigen:master Jan 21, 2021
@jchavarri jchavarri deleted the attr-translate branch January 21, 2021 21:45
Drup added a commit to Drup/opam-repository that referenced this pull request Apr 22, 2021
@Drup
[new release] tyxml-ppx, tyxml-syntax, tyxml and tyxml-jsx (4.5.0)
c7ce709 
CHANGES:

* Move all the PPXs to ppxlib
  (ocsigen/tyxml#271, Initial code by Sonja @pitag-ha Heinze)

* Add the `translate` attribute
  (ocsigen/tyxml#281 by Javier @jchavarri Chávarri)
* Update allowed `inputmode`s
  (ocsigen/tyxml#279 by Joel @joelburget Burget)
* Add the `picture` element
  (ocsigen/tyxml#263 by Stéphane @slegrand45 Legrand)
Drup added a commit to Drup/opam-repository that referenced this pull request Apr 22, 2021
@Drup
[new release] tyxml-ppx, tyxml-syntax, tyxml and tyxml-jsx (4.5.0)
8e8c295 
CHANGES:

* Move all the PPXs to ppxlib
  (ocsigen/tyxml#271, Initial code by Sonja Heinze)

* Add the `translate` attribute
  (ocsigen/tyxml#281 by Javier Chávarri)
* Update allowed `inputmode`s
  (ocsigen/tyxml#279 by Joel Burget)
* Add the `picture` element
  (ocsigen/tyxml#263 by Stéphane Legrand)
Drup added a commit to Drup/opam-repository that referenced this pull request Apr 22, 2021
@Drup
[new release] tyxml-ppx, tyxml-syntax, tyxml and tyxml-jsx (4.5.0)
b747b21 
CHANGES:

* Move all the PPXs to ppxlib
  (ocsigen/tyxml#271, Initial code by Sonja @pitag-ha Heinze)

* Add the `translate` attribute
  (ocsigen/tyxml#281 by Javier @jchavarri Chávarri)
* Update allowed `inputmode`s
  (ocsigen/tyxml#279 by Joel @joelburget Burget)
* Add the `picture` element
  (ocsigen/tyxml#263 by Stéphane @slegrand45 Legrand)
Drup added a commit to Drup/opam-repository that referenced this pull request Apr 22, 2021
@Drup
[new release] tyxml-ppx, tyxml-syntax, tyxml and tyxml-jsx (4.5.0)
ff3c4dc 
CHANGES:

* Move all the PPXs to ppxlib
  (ocsigen/tyxml#271, Initial code by Sonja @pitag-ha Heinze)

* Add the `translate` attribute
  (ocsigen/tyxml#281 by Javier Chávarri)
* Update allowed `inputmode`s
  (ocsigen/tyxml#279 by Joel Burget)
* Add the `picture` element
  (ocsigen/tyxml#263 by Stéphane Legrand)
@Drup Drup mentioned this pull request Apr 22, 2021
Merged
Drup added a commit to Drup/opam-repository that referenced this pull request Apr 22, 2021
@Drup
[new release] tyxml-ppx, tyxml-syntax, tyxml and tyxml-jsx (4.5.0)
dd331af 
CHANGES:

* Move all the PPXs to ppxlib
  (ocsigen/tyxml#271, Initial code by Sonja Heinze)

* Add the `translate` attribute
  (ocsigen/tyxml#281 by Javier Chávarri)
* Update allowed `inputmode`s
  (ocsigen/tyxml#279 by Joel Burget)
* Add the `picture` element
  (ocsigen/tyxml#263 by Stéphane Legrand)
Drup added a commit to Drup/opam-repository that referenced this pull request Apr 22, 2021
@Drup
[new release] tyxml-ppx, tyxml-syntax, tyxml and tyxml-jsx (4.5.0)
828165e 
CHANGES:

* Move all the PPXs to ppxlib
  (ocsigen/tyxml#271, Initial code by Sonja Heinze)

* Add the `translate` attribute
  (ocsigen/tyxml#281 by Javier Chávarri)
* Update allowed `inputmode`s
  (ocsigen/tyxml#279 by Joel Burget)
* Add the `picture` element
  (ocsigen/tyxml#263 by Stéphane Legrand)
Drup added a commit to Drup/opam-repository that referenced this pull request Apr 22, 2021
@Drup
[new release] tyxml-ppx, tyxml-syntax, tyxml and tyxml-jsx (4.5.0)
82ee2c0 
CHANGES:

* Move all the PPXs to ppxlib
  (ocsigen/tyxml#271, Initial code by Sonja Heinze)

* Add the `translate` attribute
  (ocsigen/tyxml#281 by Javier Chávarri)
* Update allowed `inputmode`s
  (ocsigen/tyxml#279 by Joel Burget)
* Add the `picture` element
  (ocsigen/tyxml#263 by Stéphane Legrand)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support html translate attribute
2 participants
@jchavarri @Drup