Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revoke token after trust policy look up #61

Closed
mattmoor opened this issue Jan 28, 2024 · 0 comments · Fixed by #92
Closed

Revoke token after trust policy look up #61

mattmoor opened this issue Jan 28, 2024 · 0 comments · Fixed by #92
Assignees
@mattmoor

Comments

@mattmoor
Copy link
Member

The token we create here: https://github.com/chainguard-dev/octo-sts/blob/4972f6e158ac02e903c3daaf90c0673ca0b000ac/pkg/octosts/octosts.go#L184-L191

See also: https://docs.github.com/en/rest/apps/installations?apiVersion=2022-11-28#revoke-an-installation-access-token

cc @imjasonh
@mattmoor mattmoor self-assigned this Feb 5, 2024
@mattmoor mattmoor mentioned this issue Feb 5, 2024
Merged
mattmoor added a commit that referenced this issue Feb 6, 2024
@mattmoor
Add token revocation several places. (#92)
dfd1742 
This adds a method to perform token revocation mirroring what Jason did
in the action.

This calls that method from the new prober, and in Octo STS itself where
it creates a token for looking up the trust policy (not what it hands
back to the user).

Fixes: #61

Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattmoor mattmoor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add token revocation several places. mattmoor/octo-sts
1 participant
@mattmoor