Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "SPA Day: Check type for variable in list of classes" #77

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

riseriyo
Copy link
Contributor

@riseriyo riseriyo commented Jun 2, 2023

Reverts #76
Changing back to original code. Reasoning: although we aren't using inheritance at the moment, we might in the future. using type(v) doesn't check for inheritance whereas isinstance(v, Class) does.

@riseriyo riseriyo requested a review from tahakhan0 June 2, 2023 17:02
@riseriyo riseriyo merged commit ef38e05 into main Jun 2, 2023
@riseriyo riseriyo deleted the revert-76-spa-day-use-switch-statement branch June 2, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants