Skip to content

feat: rewrite in ESM #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 20, 2023
Merged

feat: rewrite in ESM #266

merged 10 commits into from
Jun 20, 2023

Conversation

wolfy1339
Copy link
Member

Resolves #187

Behavior

Before the change?

  • The package would be written in CJS

After the change?

  • The package is now written in ESM
  • Allows the dependencies to be kept up to date to limit the security advisories

Other information

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • Switches to ESM for the module

Pull request type

Please add the corresponding label for change this PR introduces:

  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR Type: Breaking change Used to note any change that requires a major version bump labels Jun 20, 2023
@gr2m
Copy link
Contributor

gr2m commented Jun 20, 2023

Thanks so much @wolfy1339!

@gr2m gr2m merged commit 6e62a12 into main Jun 20, 2023
@gr2m gr2m deleted the esm branch June 20, 2023 22:45
@github-actions
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

wolfy1339 added a commit that referenced this pull request Jun 20, 2023
@wolfy1339
fix: correct some issues lingering from ESM migration
b14bd30 
Followup fixes to #266
@wolfy1339 wolfy1339 mentioned this pull request Jun 20, 2023
Merged
5 tasks
gr2m pushed a commit that referenced this pull request Jun 20, 2023
@wolfy1339
fix: correct some issues lingering from ESM migration (#267)
3bdae62 
Followup fixes to #266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite as ESM module
2 participants
@wolfy1339 @gr2m