Change "IssueId" to long (#2890)

* Change "IssueId" to `long` * Change "Id" to `long` in ctor * Change from `int` to `long` for issue id in "NewPullRequest"
octokit · Feb 23, 2024 · d27d1f0 · d27d1f0
1 parent 40041f2
commit d27d1f0
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs b/Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs
@@ -453,7 +453,7 @@ private static async Task<ProjectCard> CreateArchivedCardHelper(IGitHubClient gi
         return result;
     }
 
-    private static async Task<ProjectCard> CreateIssueCardHelper(IGitHubClient githubClient, int issueId, int columnId)
+    private static async Task<ProjectCard> CreateIssueCardHelper(IGitHubClient githubClient, long issueId, int columnId)
     {
         var newCard = new NewProjectCard(issueId, ProjectCardContentType.Issue);
         var result = await githubClient.Repository.Project.Card.Create(columnId, newCard);

diff --git a/Octokit.Tests.Integration/Reactive/ObservableProjectCardsClientTests.cs b/Octokit.Tests.Integration/Reactive/ObservableProjectCardsClientTests.cs
@@ -441,7 +441,7 @@ private static async Task<ProjectCard> CreateArchivedCardHelper(IObservableGitHu
         return result;
     }
 
-    private static async Task<ProjectCard> CreateIssueCardHelper(IObservableGitHubClient githubClient, int issueId, int columnId)
+    private static async Task<ProjectCard> CreateIssueCardHelper(IObservableGitHubClient githubClient, long issueId, int columnId)
     {
         var newCard = new NewProjectCard(issueId, ProjectCardContentType.Issue);
         var result = await githubClient.Repository.Project.Card.Create(columnId, newCard);

diff --git a/Octokit/Models/Request/NewPullRequest.cs b/Octokit/Models/Request/NewPullRequest.cs
@@ -32,7 +32,7 @@ public NewPullRequest(string title, string head, string baseRef)
         /// <param name="issueId">The number of an existing issue to convert into a pull request.</param>
         /// <param name="head">The branch (or git ref where your changes are implemented. In other words, the source branch/ref</param>
         /// <param name="baseRef">The base (or git ref) reference you want your changes pulled into. In other words, the target branch/ref</param>
-        public NewPullRequest(int issueId, string head, string baseRef)
+        public NewPullRequest(long issueId, string head, string baseRef)
         {
             Ensure.ArgumentNotNullOrEmptyString(head, nameof(head));
             Ensure.ArgumentNotNullOrEmptyString(baseRef, nameof(baseRef));
@@ -50,7 +50,7 @@ public NewPullRequest(int issueId, string head, string baseRef)
         /// <summary>
         /// The number of an existing issue to convert into a pull request (required if <see cref="Title"/> not provided).
         /// </summary>
-        public int? IssueId { get; private set; }
+        public long? IssueId { get; private set; }
 
         /// <summary>
         /// The branch (or git ref) you want your changes pulled into (required).

diff --git a/Octokit/Models/Response/Issue.cs b/Octokit/Models/Response/Issue.cs
@@ -12,7 +12,7 @@ public class Issue
     {
         public Issue() { }
 
-        public Issue(string url, string htmlUrl, string commentsUrl, string eventsUrl, int number, ItemState state, string title, string body, User closedBy, User user, IReadOnlyList<Label> labels, User assignee, IReadOnlyList<User> assignees, Milestone milestone, int comments, PullRequest pullRequest, DateTimeOffset? closedAt, DateTimeOffset createdAt, DateTimeOffset? updatedAt, int id, string nodeId, bool locked, Repository repository, ReactionSummary reactions, LockReason? activeLockReason, ItemStateReason? stateReason)
+        public Issue(string url, string htmlUrl, string commentsUrl, string eventsUrl, int number, ItemState state, string title, string body, User closedBy, User user, IReadOnlyList<Label> labels, User assignee, IReadOnlyList<User> assignees, Milestone milestone, int comments, PullRequest pullRequest, DateTimeOffset? closedAt, DateTimeOffset createdAt, DateTimeOffset? updatedAt, long id, string nodeId, bool locked, Repository repository, ReactionSummary reactions, LockReason? activeLockReason, ItemStateReason? stateReason)
         {
             Id = id;
             NodeId = nodeId;
@@ -45,7 +45,7 @@ public Issue(string url, string htmlUrl, string commentsUrl, string eventsUrl, i
         /// <summary>
         /// The internal Id for this issue (not the issue number)
         /// </summary>
-        public int Id { get; private set; }
+        public long Id { get; private set; }
 
         /// <summary>
         /// GraphQL Node Id