-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add active lock reason to PR #2543
add active lock reason to PR #2543
Conversation
create ILockUnlockClient so both IIssuesClient and IPullRequestClient can access lock and unlock methods.
I have extracted the lock/unlock methods from IIssuesClient to a new ILockUnlockClient, which is available in both the IIssuesClient and IPullRequestClient, so both clients can use the ILockUnlockClient. I need a review for this PR and any feedback. I have intentionally left out the refactoring on the Reactive project, I will get to that once I get a review. |
Hi @notauserx, thanks for this contribution
|
Thanks @JonruAlveus for the feedback. I will also update the relevant readme and the linqpad samples in the PR. |
@JonruAlveus I have updated the docs in the Issues.md. I did not find any relevant linqpad samples to update. Please let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super happy with everything you’ve done here, if you can fix up the warnings I’d be happy to approve for merge!
release_notes: Reworks how Locking and Unlocking works on Issues and adds Locking and Unlocking to Pull Requests |
add active lock reason to PR.
Since every pull request is an issue and the lock and unlock are on the IIssuesClient, updates the docs to reflect the design.
Fixes #2248