Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Allow users to fetch all commits for two commits comparision #2690

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

zolroman
Copy link
Contributor

@zolroman zolroman commented Mar 28, 2023

Behavior

Before the change?

Method Compare in RepositoryCommitsClient returns CompareResult with limit in collections Commits and Files up to 250 items.

After the change?

Added methods overloads with the parameter ApiOptions that allows user to fetch all commits and files for comparision


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

Pull request type

Type: Feature


Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a couple of quick questions! Thank you for contributing.

Octokit/Clients/RepositoryCommitsClient.cs Show resolved Hide resolved
Octokit/Clients/RepositoryCommitsClient.cs Show resolved Hide resolved
@kfcampbell kfcampbell merged commit 7b1fa04 into octokit:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants