Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in support for enterprise audit logs #2702

Merged
merged 7 commits into from
May 9, 2023

Conversation

gitasaurus
Copy link
Contributor

@gitasaurus gitasaurus commented Apr 21, 2023

Resolves #2701


Behavior

Before the change?

After the change?

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@gitasaurus
Copy link
Contributor Author

@kfcampbell , do you have any guidance on fixing ApiConnectionTests+TheGetAllMethod?

@kfcampbell
Copy link
Member

@gitasaurus I'm currently struggling to reproduce this locally. Running unit tests using dotnet test is passing for me on .NET 7.0.102. I'm not sure if it's failing using .NET 5 or .NET 6 during this test, though perhaps we should think about removing .NET 5 testing as it's reached end-of-life.

@gitasaurus
Copy link
Contributor Author

Thanks for looking at this. I will update this pull request tomorrow. I found that the paging for Audit Logs does not work the same as the other APIs. I have added a way to address that. Please hold off on approving this until then.

@gitasaurus
Copy link
Contributor Author

@kfcampbell, this change added in the ability to stop retrieving Audit Logs when a search string is found (e.g. a document id or timestamp), allowing users to retrieve the latest log until they encounter a known log.

@kfcampbell
Copy link
Member

👍, although the build is still failing so I can't approve/merge until that's set.

@gitasaurus
Copy link
Contributor Author

@kfcampbell , fixed the failing tests.

@nickfloyd nickfloyd added Priority: Normal Type: Feature New feature or request labels May 9, 2023
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitasaurus Thanks for adding this feature here! ❤️

@nickfloyd nickfloyd merged commit 3c82ff3 into octokit:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEAT]: Support for the Enterprise Audit Log
4 participants