-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in support for enterprise audit logs #2702
Conversation
@kfcampbell , do you have any guidance on fixing ApiConnectionTests+TheGetAllMethod? |
@gitasaurus I'm currently struggling to reproduce this locally. Running unit tests using |
Thanks for looking at this. I will update this pull request tomorrow. I found that the paging for Audit Logs does not work the same as the other APIs. I have added a way to address that. Please hold off on approving this until then. |
@kfcampbell, this change added in the ability to stop retrieving Audit Logs when a search string is found (e.g. a document id or timestamp), allowing users to retrieve the latest log until they encounter a known log. |
👍, although the build is still failing so I can't approve/merge until that's set. |
@kfcampbell , fixed the failing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gitasaurus Thanks for adding this feature here! ❤️
Resolves #2701
Behavior
Before the change?
After the change?
Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug
Type: Feature
Type: Documentation
Type: Maintenance