Fix runner application deserialization #2704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2703
Behavior
Before the change?
ListAllRunnerApplicationsForOrganization
in theActionsSelfHostedRunnersClient
After the change?
Other information
I fixed the issue by removing the extra
IReadOnlyList
layer sinceApiConnection.GetAll
already returns anIReadOnlyList
. I also made a few other updates to theRunnerApplication
model:RunnerLabel
model since theLabel
model is for issue/PR labels and didn't match the properties in the JSON payloadAdditional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Bugfix
Please add the corresponding label for change this PR introduces:
Type: Bug
Type: Feature
Type: Documentation
Type: Maintenance