Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SearchIssuesRequest): wrap label in quotes if it contains spaces #2767

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

capdiem
Copy link
Contributor

@capdiem capdiem commented Aug 26, 2023

Resolves #2762


Before the change?

request.Labels = new[] { "bug,resolved,help wanted" } // label:"bug,resolved,help wanted"

After the change?

request.Labels = new[] { "bug,resolved,help wanted" } // label:bug,resolved,"help wanted"

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@capdiem capdiem changed the title 🐛 fix(SearchIssuesRequest): wrap label in quotes if it contains spaces fix(SearchIssuesRequest): wrap label in quotes if it contains spaces Aug 26, 2023
@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented label Aug 31, 2023
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions @capdiem ❤️

@nickfloyd nickfloyd merged commit c40c6b8 into octokit:main Aug 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: The Labels in SearchIssuesRequest is flawed
2 participants