Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suspended_at and suspended_by to the Installation model #2779

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

lineville
Copy link
Contributor

@lineville lineville commented Sep 20, 2023

Resolves #2777 by adding suspended_at and suspended_by properties to the Installation model. This will allow consumers of the List GitHub Installations API to filter out suspended installations.


Before the change?

  • Calls to list GitHub App installations would not include the suspended_at and suspended_by properties.

After the change?

  • Calls to list GitHub App installations will include both the suspended_at and suspended_by properties.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Octokit/Octokit.csproj Outdated Show resolved Hide resolved
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lineville Thanks for the contribs here! ❤️

@nickfloyd nickfloyd added the Type: Feature New feature or request label Sep 21, 2023
@nickfloyd nickfloyd merged commit dcc31b8 into octokit:main Sep 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add suspended_by and suspended_at properties to the Installation model
2 participants