Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add Advanced Security Properties to Repository Get/Update #2858

Closed
wants to merge 7 commits into from

Conversation

SlyckLizzie
Copy link
Contributor

@SlyckLizzie SlyckLizzie commented Jan 21, 2024


Before the change?

  • Repository get/update did not implement Advanced Security objects

After the change?

  • Repository get/update implements Advanced Security properties

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@kfcampbell
Copy link
Member

Do you mind explaining a little more why this is a breaking change? It looks purely additive at the moment.

@SlyckLizzie
Copy link
Contributor Author

SlyckLizzie commented Jan 22, 2024

For the UpdateRepository method, I am unable to make the SecurityAndAnalysis object nullable because it requires the c# language target to be 8 or higher in order to null ref objects. This project is targeting C# 7.3.

@SlyckLizzie
Copy link
Contributor Author

@kfcampbell - Do you need any additional information for this?

@SlyckLizzie
Copy link
Contributor Author

Accidentally PR'd this from main on my end. Going to re-do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants