Repository Get Archive Link #765
Conversation
|
When this will be merged? |
| @@ -1,5 +1,6 @@ | |||
| using System; | |||
| using System.Reactive.Threading.Tasks; | |||
| using Microsoft.SqlServer.Server; | |||
There was a problem hiding this comment.
Uhm.......😲
I have no idea where that would have come from...I will of course remove said reference quicker than quick 😁
From: Brendan Forstermailto:notifications@github.com
Sent: 23/04/2015 3:10
To: octokit/octokit.netmailto:octokit.net@noreply.github.com
Cc: Henrik Anderssonmailto:henrik.a.andersson@outlook.com
Subject: Re: [octokit.net] Repository Get Archive Link (#765)
@@ -1,5 +1,6 @@
using System;
using System.Reactive.Threading.Tasks;
+using Microsoft.SqlServer.Server;
Wait, what?
Reply to this email directly or view it on GitHub:
https://github.com/octokit/octokit.net/pull/765/files#r28893592
|
@NikolayIT not sure - were you waiting the complete "get actual content" step as well? that code hasn't been implemented yet... |
|
That'd be my fault, I was trying to come up w with a good solution for getting the contents of the file and then we got super busy at work. I might have some time this weekend to have another look at it again. From: Nikolay Kostovmailto:notifications@github.com When this will be merged? Reply to this email directly or view it on GitHub: |
hnrkndrssn
force-pushed
the
repository-archivelink
branch
from
5aa310c
to
86a53c0
Compare
|
@alfhenrik if you find yourself still struggling to make time for it, I'm happy to short this PR and just merge in the archive link stuff. |
|
Happy for you to merge this PR now, and I'll send a new one for the content stuff 👍 |
| [IntegrationTest] | ||
| public async Task GetsArchiveLinkAsTarball() | ||
| { | ||
| var github = new GitHubClient(new ProductHeaderValue("OctokitTests")) |
There was a problem hiding this comment.
💄 just use Helper.GetAuthenticatedClient() for these integration tests
There was a problem hiding this comment.
That's what ctrl-c, ctrl-v gets you, shouldn't trust previous methods in same class 😇 (just kidding)
hnrkndrssn
force-pushed
the
repository-archivelink
branch
from
86a53c0
to
0ac98e4
Compare
|
|
|
@NikolayIT this just went out in |
|
@shiftkey, awesome! Thanks! |
Partial fix for #748
[ ] Get the actual content of the archive.... 🎅 🎁Will send a separate PR for this one