-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searching repos #951
Searching repos #951
Conversation
Created = DateRange.LessThan(new DateTime(2015, 1, 1)), | ||
|
||
// or maybe the last time this repo was updated? | ||
Updated = DateRange.GreaterThan(new DateTime(2013, 1, 1)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're demonstrating DateRange
here could we drop this usage and just include DateRange.Between
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's cool...
Whilst I was writing this, I was thinking... will you want us to describe the daterange
class as this is a documentation, or for now will we simply expand on the documentation as and when?
Just one little question. Everything else is 💎 |
@shiftkey That's done now. |
|
||
Finding repositories via various criteria. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a bit basic - could we jazz this up a bit?
e.g.
To search for repositories using Octokit you need to create a
SearchRepositoriesRequest
and populate it with the search criteria.
Sorry, a couple more things while I'm in here. |
Let me know how that change works for ya. |
|
||
To search for repositories using Octokit you need to create a ```SearchRepositoriesRequest``` and populate it with the search criteria. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💄 single ` here should work fine too
Ok done those fixes. |
Let me kickstart my documentation contribution with this PR.
Relates to #948
Let me know what you want me to improve on.
/cc @shiftkey
This PR negates #950