Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching repos #951

Merged
merged 7 commits into from
Oct 30, 2015
Merged

Searching repos #951

merged 7 commits into from
Oct 30, 2015

Conversation

hahmed
Copy link
Contributor

@hahmed hahmed commented Oct 29, 2015

Let me kickstart my documentation contribution with this PR.

Relates to #948

Let me know what you want me to improve on.

/cc @shiftkey

This PR negates #950

Created = DateRange.LessThan(new DateTime(2015, 1, 1)),

// or maybe the last time this repo was updated?
Updated = DateRange.GreaterThan(new DateTime(2013, 1, 1)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're demonstrating DateRange here could we drop this usage and just include DateRange.Between here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool...

Whilst I was writing this, I was thinking... will you want us to describe the daterange class as this is a documentation, or for now will we simply expand on the documentation as and when?

@shiftkey
Copy link
Member

Just one little question. Everything else is 💎

@hahmed
Copy link
Contributor Author

hahmed commented Oct 30, 2015

@shiftkey That's done now.


Finding repositories via various criteria.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit basic - could we jazz this up a bit?

e.g.

To search for repositories using Octokit you need to create a SearchRepositoriesRequest and populate it with the search criteria.

@shiftkey
Copy link
Member

Sorry, a couple more things while I'm in here.

@hahmed
Copy link
Contributor Author

hahmed commented Oct 30, 2015

Let me know how that change works for ya.


To search for repositories using Octokit you need to create a ```SearchRepositoriesRequest``` and populate it with the search criteria.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💄 single ` here should work fine too

@hahmed
Copy link
Contributor Author

hahmed commented Oct 30, 2015

Ok done those fixes.

shiftkey added a commit that referenced this pull request Oct 30, 2015
@shiftkey shiftkey merged commit d1db00a into octokit:documentation Oct 30, 2015
@shiftkey
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants