Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faraday 0.16.0 release breaking Octokit #1155

Closed
stuyam opened this issue Sep 27, 2019 · 3 comments
Closed

Faraday 0.16.0 release breaking Octokit #1155

stuyam opened this issue Sep 27, 2019 · 3 comments

Comments

@stuyam
Copy link

stuyam commented Sep 27, 2019

I'm getting this error:

/usr/local/bundle/gems/octokit-4.14.0/lib/octokit/middleware/follow_redirects.rb:14:in `<module:Middleware>': uninitialized constant Faraday::Error::ClientError (NameError)
Did you mean?  Faraday::ClientError

It looks like a new version of Faraday just came out 2 hours ago and it is breaking one of the dependencies you use. https://github.com/lostisland/faraday/releases/tag/v0.16.0

May have to lock the version number or something.
@stuyam stuyam mentioned this issue Sep 27, 2019
Closed
@stuyam
Copy link
Author

stuyam commented Sep 27, 2019

Hopefully this PR will fix this and make it backwards compatible: lostisland/faraday#1030

@stuyam
Copy link
Author

stuyam commented Sep 27, 2019

Looks like there is an open PR here too: #1154

@greysteil greysteil mentioned this issue Sep 27, 2019
Merged
@adangel adangel mentioned this issue Sep 28, 2019
Closed
@dawidd6 dawidd6 mentioned this issue Sep 28, 2019
Closed
@steel steel mentioned this issue Oct 3, 2019
Closed
@takke takke mentioned this issue Oct 4, 2019
Closed
@ArturT ArturT mentioned this issue Oct 13, 2019
Closed
@indigok
Copy link

indigok commented Jan 2, 2020

#1154 was merged and a new release with the fix has been released so closing this out ✨

@indigok indigok closed this as completed Jan 2, 2020
BanzaiMan added a commit to travis-ci/dpl that referenced this issue Jan 6, 2020
@BanzaiMan
Update octokit dependency to ~> 4.15.0
efa9c82 
Resolves https://travis-ci.community/t/there-was-an-error-while-trying-to-load-the-gem-octokit/6708
by using the new octokit release, which fixes dependency issue (See
octokit/octokit.rb#1155).
@BanzaiMan BanzaiMan mentioned this issue Jan 6, 2020
Closed
sumitgpt added a commit to sumitgpt/pairing_matrix that referenced this issue Mar 3, 2020
@sumitgpt
update octokit version to fix issue with dependency faraday
93d4d91 
Github issue link - octokit/octokit.rb#1155
@sumitgpt sumitgpt mentioned this issue Mar 3, 2020
Merged
HuangFJ added a commit to HuangFJ/github-app-template that referenced this issue Aug 21, 2022
@HuangFJ
Update Gemfile
10fae3c 
a new version of Faraday release breaking Octokit, reference to octokit/octokit.rb#1155
@HuangFJ HuangFJ mentioned this issue Aug 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stuyam @indigok