Rework request review #1047
Merged
Rework request review #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setup for the namespace should only be adding the collaborator. The setup for each individual method needs to do different things, depending on what the method does: - we need to clean up after the create method - we need to create the review before the delete method - we need to both create the review and clean up before the list method
Order them as: list, create, delete. This matches the order of the docs.
This changes the signature in a backwards-compatible manner, as evidenced by the unchanged tests which continue to pass. This regenerates the VCR cassettes, as we needed to hit the API to be certain that the new code actually does what's expected.
Co-Authored-By: Katrina Owen <katrina.owen@gmail.com>
Co-Authored-By: Katrina Owen <katrina.owen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1037