Handle commonjs export in is-plain-object
#51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
reviewed
May 12, 2019
hughrawlinson
commented
May 12, 2019
| module.exports = request | ||
|
|
||
| const isPlainObject = require('is-plain-object') | ||
| const isPlainObject = require('is-plain-object/index.cjs.js') |
There was a problem hiding this comment.
This should resolve the cjs version of the library that you were depending on before is-plain-object@3. Importing that seems like a better idea than the weird hacky IIFE, and hopefully it'll be possible to resolve this in a way that doesn't require any of this.
|
🎉 This PR is included in version 3.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would solve my issue in octokit/graphql.js#20
fixes octokit/graphql.js#20