Skip to content

Handle commonjs export in is-plain-object #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2019
Merged

Handle commonjs export in is-plain-object #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
203571e
Handle commonjs export in `is-plain-object`
hughrawlinson May 12, 2019
3ff33ac
Alternative way to resolve this
hughrawlinson May 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = request

const isPlainObject = require('is-plain-object')
const isPlainObject = require('is-plain-object/index.cjs.js')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should resolve the cjs version of the library that you were depending on before is-plain-object@3. Importing that seems like a better idea than the weird hacky IIFE, and hopefully it'll be possible to resolve this in a way that doesn't require any of this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, great, thank you!

const nodeFetch = require('node-fetch').default

const getBuffer = require('./get-buffer-response')
Expand Down