Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove legacy org and organization parameters from octokit.repos.createFork() again #46

Merged
merged 1 commit into from
Apr 21, 2021
Merged

fix: remove legacy org and organization parameters from octokit.repos.createFork() again #46

merged 1 commit into from
Apr 21, 2021

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Apr 21, 2021

fixes #45

@gr2m gr2m added Type: Bug Something isn't working as documented typescript labels Apr 21, 2021
@ghost ghost added this to Inbox in JS Apr 21, 2021
@ghost ghost moved this from Inbox to Bugs in JS Apr 21, 2021
@gr2m gr2m mentioned this pull request Apr 21, 2021
Closed
@gr2m gr2m merged commit 8263ce9 into master Apr 21, 2021
JS automation moved this from Bugs to Done Apr 21, 2021
@gr2m gr2m deleted the update-to-latest-rest-endpoint-methods-plugin branch April 21, 2021 18:30
@github-actions
Copy link
Contributor

🎉 This PR is included in version 18.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dscho
Copy link

dscho commented Apr 26, 2021

I just got notified by dependabot about this update, but the PR lets the test suite fail.

Is it possible that the rest.users.getByUsername() function's result newly marks its fields as any by mistake? At least that's what https://github.com/gitgitgadget/gitgitgadget/pull/541/checks?check_run_id=2438187738#step:9:24 suggests (the corresponding source code is here).

@gr2m
Copy link
Contributor Author

gr2m commented Apr 26, 2021

Hmm you are right, the response data object is correct, but all values are set to any for some reason. I'm quite sure it's unrelated to this particular PR though, could you create a separate issue so you and others can track our progress on fixing it better?

@webstech webstech mentioned this pull request Apr 27, 2021
Closed
@gr2m
Copy link
Contributor Author

gr2m commented Apr 27, 2021

opened at octokit/openapi-types.ts#77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented typescript
Projects
No open projects
JS
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't get probot/@octokit/rest/plugin-rest-endpoint-methods to compile
2 participants
@gr2m @dscho