Skip to content

ci(workflow): fix test workflow to assure it is not skipped if test_matrix fails #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2022
Merged

ci(workflow): fix test workflow to assure it is not skipped if test_matrix fails #735

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dcaac9
ci(workflow): fix test workflow to assure it is not skipped if test_m…
oscard0m Sep 1, 2022
87ffe3f
Update test.yml
oscard0m Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ jobs:
- 18
name: Node ${{ matrix.node }}
steps:
- uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3
- uses: actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93 # tag=v3
- uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b
- uses: actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93
with:
node-version: ${{ matrix.node }}
cache: npm
Expand All @@ -29,10 +29,13 @@ jobs:
runs-on: ubuntu-latest
needs: test_matrix
steps:
- uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3
- uses: actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93 # tag=v3
- run: exit 1
if: ${{ needs.test_matrix.result != 'success' }}
- uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b
- uses: actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93
with:
cache: npm
node-version: 16
- run: npm ci
- run: npm run validate:ts
if: ${{ always() }}