Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the test environment to OKD #41

Closed
wants to merge 7 commits into from
Closed

Conversation

ozonophore
Copy link
Collaborator

  • Helm templates have been added for running tests in the environment deployed in OKD.
  • Test parameters have been moved to an external file.
  • Tasks have been created for deploying the environment in OKD and for deleting the environment by ReleaseName.

@ozonophore ozonophore added the enhancement New feature or request label May 31, 2024
@ozonophore ozonophore self-assigned this May 31, 2024
Copy link

gitguardian bot commented May 31, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7831874 Triggered Generic Password 54f65ea test-common/src/main/kotlin/org/octopusden/octopus/vcsfacade/BaseVcsFacadeTest.kt View secret
7831874 Triggered Generic Password 54f65ea server/src/test/resources/test-properties.yaml View secret
11399842 Triggered Generic High Entropy Secret 978d16b deploy/chart/files/application-gitea.yml View secret
11399842 Triggered Generic High Entropy Secret 978d16b ft/src/ft/kotlin/org/octopusden/octopus/vcsfacade/VcsFacadeFunctionalTestGitea.kt View secret
11399842 Triggered Generic High Entropy Secret 95a716d ft/src/ft/kotlin/org/octopusden/octopus/vcsfacade/VcsFacadeFunctionalTestGitea.kt View secret
11399842 Triggered Generic High Entropy Secret 95a716d ft/src/ft/kotlin/org/octopusden/octopus/vcsfacade/VcsFacadeFunctionalTestGitea.kt View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@ozonophore ozonophore changed the title Integro change Switch the test environment to OKD May 31, 2024
fishinitself
fishinitself previously approved these changes Jul 10, 2024
deploy/README.md Outdated Show resolved Hide resolved
deploy/README.md Outdated Show resolved Hide resolved
deploy/README.md Outdated Show resolved Hide resolved
deploy/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@pgorbachev pgorbachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ozonophore
Please add reference or link from main Read.me to deploy readme

deploy/README.md Show resolved Hide resolved
pgorbachev
pgorbachev previously approved these changes Jul 20, 2024
@@ -16,3 +16,24 @@
## Features / limitations

VCS servers must be configured to use default ports for http(s)/ssh (urls must not contain port specified).

## Using local.properties for Custom Configuration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем нужен этот механизм, если при локальной разработке можно вести свои property в $home/.gradle/gradle.properties ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это позволит вести не одни параметры для всех проектов, а для каждого свой. Если что то надо поменять именно в данном проекте оно не будет влиять на все другие. Мне показалось это удобным, если это как то мешает или вредит проекту, готов убрать


val bitbucketLicense: String by project

commandLine("helm", "upgrade", "--wait"
Copy link
Collaborator

@CamaradeRoman CamaradeRoman Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я правильно понимаю, что не нашлось готового решения (плагина) для автоматизации разворачивания окружения в ODK мы просто автоматизировали вызовы OpenShift/Helm CLI?

Мне кажется, что в таком случае стоит после внедрения первого пилота рассмотреть вариант создания собственного gradle плагина.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Глубоким поиском каких то плагинов я не занимался. Если есть какие то предложения или рекомендации, можно заменить.

storage: 5Gi

###############################
# Deplyoment Gitea
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "Deplyoment"

@CamaradeRoman CamaradeRoman deleted the integro_change branch September 26, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

4 participants