-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch the test environment to OKD #41
Conversation
ozonophore
commented
May 31, 2024
- Helm templates have been added for running tests in the environment deployed in OKD.
- Test parameters have been moved to an external file.
- Tasks have been created for deploying the environment in OKD and for deleting the environment by ReleaseName.
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
7831874 | Triggered | Generic Password | 54f65ea | test-common/src/main/kotlin/org/octopusden/octopus/vcsfacade/BaseVcsFacadeTest.kt | View secret |
7831874 | Triggered | Generic Password | 54f65ea | server/src/test/resources/test-properties.yaml | View secret |
11399842 | Triggered | Generic High Entropy Secret | 978d16b | deploy/chart/files/application-gitea.yml | View secret |
11399842 | Triggered | Generic High Entropy Secret | 978d16b | ft/src/ft/kotlin/org/octopusden/octopus/vcsfacade/VcsFacadeFunctionalTestGitea.kt | View secret |
11399842 | Triggered | Generic High Entropy Secret | 95a716d | ft/src/ft/kotlin/org/octopusden/octopus/vcsfacade/VcsFacadeFunctionalTestGitea.kt | View secret |
11399842 | Triggered | Generic High Entropy Secret | 95a716d | ft/src/ft/kotlin/org/octopusden/octopus/vcsfacade/VcsFacadeFunctionalTestGitea.kt | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
f9bb697
to
b0ed662
Compare
b0ed662
to
ef74e4b
Compare
ef74e4b
to
430bf06
Compare
430bf06
to
a6c358f
Compare
a6c358f
to
54f65ea
Compare
273dd0c
to
5c143db
Compare
5c143db
to
1fd36d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ozonophore
Please add reference or link from main Read.me to deploy readme
@@ -16,3 +16,24 @@ | |||
## Features / limitations | |||
|
|||
VCS servers must be configured to use default ports for http(s)/ssh (urls must not contain port specified). | |||
|
|||
## Using local.properties for Custom Configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем нужен этот механизм, если при локальной разработке можно вести свои property в $home/.gradle/gradle.properties ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это позволит вести не одни параметры для всех проектов, а для каждого свой. Если что то надо поменять именно в данном проекте оно не будет влиять на все другие. Мне показалось это удобным, если это как то мешает или вредит проекту, готов убрать
|
||
val bitbucketLicense: String by project | ||
|
||
commandLine("helm", "upgrade", "--wait" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я правильно понимаю, что не нашлось готового решения (плагина) для автоматизации разворачивания окружения в ODK мы просто автоматизировали вызовы OpenShift/Helm CLI?
Мне кажется, что в таком случае стоит после внедрения первого пилота рассмотреть вариант создания собственного gradle плагина.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Глубоким поиском каких то плагинов я не занимался. Если есть какие то предложения или рекомендации, можно заменить.
storage: 5Gi | ||
|
||
############################### | ||
# Deplyoment Gitea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo "Deplyoment"