When Accessing a Slice in an rodata struct, it can still be modified

[kranasAngel]

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

related to the resolved: #3964

• Operating System & Odin Version:
  macos sonoma | dev-2024-07:bc5b41938

Expected Behavior

Expecting a bus error like when trying to modify a readonly array in a struct

Current Behavior

What is the current behavior? the slice is modified successfully

Steps to Reproduce

MyStruct :: struct { nums : []int, arr_nums : [3]int}

@(rodata)
my_struct : MyStruct = MyStruct{nums = []int {1,2,3}, arr_nums = [3]int {4,5,6}}

ret_m_slice :: proc() -> MyStruct {
    return my_struct;
}

main :: proc() {
    x := ret_m_slice();
    fmt.println(x);
    fmt.println("modify slice local");
    x.nums[1] = 11;
    fmt.println(ret_m_slice());
    fmt.println("modify slice direct");
    my_struct.nums[1] = 99;
    fmt.println(ret_m_slice());
    //throws error                                                                                                                                                     
    fmt.println("modify arr");
    my_struct.arr_nums[1] = 22;
    fmt.println(ret_m_slice());
    
}

Failure Logs

odin build temp && ./temp.bin                                                                                                  
MyStruct{nums = [1, 2, 3], arr_nums = [4, 5, 6]}                                                                                                                       
modify slice local                                                                                                                                                     
MyStruct{nums = [1, 11, 3], arr_nums = [4, 5, 6]}                                                                                                                      
modify slice direct                                                                                                                                                    
MyStruct{nums = [1, 99, 3], arr_nums = [4, 5, 6]}                                                                                                                      
modify arr                                                                                                                                                             
zsh: bus error  ./temp.bin

[kranasAngel]

Fixed by b0fe777