Skip to content

Commit 900846f

Browse files
committed
[FIX] im_livechat: correct author name display for visitor messages in demo data
Before this commit: Messages posted by visitors in demo data incorrectly displayed the author name as 'Odoobot' instead of 'Visitor'. This happened because the messages created for visitors in the demo data do not have the author_id field explicitly set to False, which causes the _message_compute_author() method to compute the author. After this commit: The author name for messages posted by visitors in demo data is correctly displayed as 'Visitor'. Task-4420677 closes odoo#192003 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
1 parent 3f13cc5 commit 900846f

8 files changed

+25
-0
lines changed

addons/im_livechat/demo/im_livechat_channel/im_livechat_session_1.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
<field name="model">discuss.channel</field>
3737
<field name="res_id" ref="im_livechat.livechat_channel_session_1"/>
3838
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_1_guest"/>
39+
<field name="author_id"/>
3940
<field name="email_from">Visitor</field>
4041
<field name="body">I'm looking for an application to record my timesheet, any tips?</field>
4142
<field name="message_type">comment</field>
@@ -55,6 +56,7 @@
5556
<field name="model">discuss.channel</field>
5657
<field name="res_id" ref="im_livechat.livechat_channel_session_1"/>
5758
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_1_guest"/>
59+
<field name="author_id"/>
5860
<field name="email_from">Visitor</field>
5961
<field name="body">Great! Thanks for the info</field>
6062
<field name="message_type">comment</field>
@@ -74,6 +76,7 @@
7476
<field name="model">discuss.channel</field>
7577
<field name="res_id" ref="im_livechat.livechat_channel_session_1"/>
7678
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_1_guest"/>
79+
<field name="author_id"/>
7780
<field name="subtype_id" ref="mail.mt_note"/>
7881
<field name="message_type">notification</field>
7982
<field eval="DateTime.today() + relativedelta(months=-1, days=-0, minutes=5, seconds=25)" name="date"/>

addons/im_livechat/demo/im_livechat_channel/im_livechat_session_10.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
<record id="livechat_channel_session_10_message_1" model="mail.message">
2828
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_10_guest"/>
29+
<field name="author_id"/>
2930
<field name="email_from">Visitor</field>
3031
<field name="record_name">Visitor</field>
3132
<field name="date" eval="datetime.now() - timedelta(days=1)"/>
@@ -50,6 +51,7 @@
5051
</record>
5152
<record id="livechat_channel_session_10_message_3" model="mail.message">
5253
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_10_guest"/>
54+
<field name="author_id"/>
5355
<field name="email_from">Visitor</field>
5456
<field name="record_name">Visitor</field>
5557
<field name="date" eval="datetime.now() - timedelta(days=1, seconds=-25)"/>
@@ -65,6 +67,7 @@
6567
<field name="model">discuss.channel</field>
6668
<field name="res_id" ref="im_livechat.livechat_channel_session_10"/>
6769
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_10_guest"/>
70+
<field name="author_id"/>
6871
<field name="subtype_id" ref="mail.mt_note"/>
6972
<field name="message_type">notification</field>
7073
<field eval="datetime.now() - timedelta(days=1, seconds=-60)" name="date"/>

addons/im_livechat/demo/im_livechat_channel/im_livechat_session_11.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
<record id="livechat_channel_session_11_message_1" model="mail.message">
2626
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_11_guest"/>
27+
<field name="author_id"/>
2728
<field name="record_name">Visitor</field>
2829
<field name="date" eval="datetime.now()"/>
2930
<field name="create_date" eval="datetime.now()"/>
@@ -48,6 +49,7 @@
4849
</record>
4950
<record id="livechat_channel_session_11_message_3" model="mail.message">
5051
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_11_guest"/>
52+
<field name="author_id"/>
5153
<field name="record_name">Visitor</field>
5254
<field name="date" eval="datetime.now() - timedelta(seconds=-25)"/>
5355
<field name="create_date" eval="datetime.now() - timedelta(seconds=-25)"/>

addons/im_livechat/demo/im_livechat_channel/im_livechat_session_2.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
<field name="model">discuss.channel</field>
3636
<field name="res_id" ref="im_livechat.livechat_channel_session_2"/>
3737
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_2_guest"/>
38+
<field name="author_id"/>
3839
<field name="email_from">Visitor</field>
3940
<field name="body">I was wondering if Odoo has an application to easily manage social media for my business..</field>
4041
<field name="message_type">comment</field>
@@ -54,6 +55,7 @@
5455
<field name="model">discuss.channel</field>
5556
<field name="res_id" ref="im_livechat.livechat_channel_session_2"/>
5657
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_2_guest"/>
58+
<field name="author_id"/>
5759
<field name="email_from">Visitor</field>
5860
<field name="body">Awesome, thanks!</field>
5961
<field name="message_type">comment</field>
@@ -73,6 +75,7 @@
7375
<field name="model">discuss.channel</field>
7476
<field name="res_id" ref="im_livechat.livechat_channel_session_2"/>
7577
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_2_guest"/>
78+
<field name="author_id"/>
7679
<field name="subtype_id" ref="mail.mt_note"/>
7780
<field name="message_type">notification</field>
7881
<field eval="DateTime.today() + relativedelta(months=-1, days=-1, minutes=11)" name="date"/>

addons/im_livechat/demo/im_livechat_channel/im_livechat_session_5.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
<field name="model">discuss.channel</field>
3636
<field name="res_id" ref="im_livechat.livechat_channel_session_5"/>
3737
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_5_guest"/>
38+
<field name="author_id"/>
3839
<field name="email_from">Visitor</field>
3940
<field name="body">Hello, it seems that I can't log in to my database. Can you help?</field>
4041
<field name="message_type">comment</field>
@@ -54,6 +55,7 @@
5455
<field name="model">discuss.channel</field>
5556
<field name="res_id" ref="im_livechat.livechat_channel_session_5"/>
5657
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_5_guest"/>
58+
<field name="author_id"/>
5759
<field name="email_from">Visitor</field>
5860
<field name="body">Ok.. Will do, thanks</field>
5961
<field name="message_type">comment</field>
@@ -64,6 +66,7 @@
6466
<field name="model">discuss.channel</field>
6567
<field name="res_id" ref="im_livechat.livechat_channel_session_5"/>
6668
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_5_guest"/>
69+
<field name="author_id"/>
6770
<field name="subtype_id" ref="mail.mt_note"/>
6871
<field name="message_type">notification</field>
6972
<field eval="DateTime.today() + relativedelta(months=-2, days=-4, minutes=33)" name="date"/>

addons/im_livechat/demo/im_livechat_channel/im_livechat_session_6.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
<field name="model">discuss.channel</field>
3636
<field name="res_id" ref="im_livechat.livechat_channel_session_6"/>
3737
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_6_guest"/>
38+
<field name="author_id"/>
3839
<field name="email_from">Visitor</field>
3940
<field name="body">Hello, I'm a bit lost in the Invetory module, is there some documentation I could find?</field>
4041
<field name="message_type">comment</field>
@@ -54,6 +55,7 @@
5455
<field name="model">discuss.channel</field>
5556
<field name="res_id" ref="im_livechat.livechat_channel_session_6"/>
5657
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_6_guest"/>
58+
<field name="author_id"/>
5759
<field name="email_from">Visitor</field>
5860
<field name="body">Thanks!</field>
5961
<field name="message_type">comment</field>
@@ -64,6 +66,7 @@
6466
<field name="model">discuss.channel</field>
6567
<field name="res_id" ref="im_livechat.livechat_channel_session_6"/>
6668
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_6_guest"/>
69+
<field name="author_id"/>
6770
<field name="subtype_id" ref="mail.mt_note"/>
6871
<field name="message_type">notification</field>
6972
<field eval="DateTime.today() + relativedelta(months=-3, days=-5, minutes=35)" name="date"/>

addons/im_livechat/demo/im_livechat_channel/im_livechat_session_8.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
<field name="model">discuss.channel</field>
3636
<field name="res_id" ref="im_livechat.livechat_channel_session_8"/>
3737
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_8_guest"/>
38+
<field name="author_id"/>
3839
<field name="body">Heeeey Marc, how are you?</field>
3940
<field name="message_type">comment</field>
4041
<field name="subtype_id" ref="mail.mt_comment"/>
@@ -53,6 +54,7 @@
5354
<field name="model">discuss.channel</field>
5455
<field name="res_id" ref="im_livechat.livechat_channel_session_8"/>
5556
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_8_guest"/>
57+
<field name="author_id"/>
5658
<field name="body">I'm great, thanks for asking!</field>
5759
<field name="message_type">comment</field>
5860
<field name="subtype_id" ref="mail.mt_comment"/>
@@ -62,6 +64,7 @@
6264
<field name="model">discuss.channel</field>
6365
<field name="res_id" ref="im_livechat.livechat_channel_session_8"/>
6466
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_8_guest"/>
67+
<field name="author_id"/>
6568
<field name="subtype_id" ref="mail.mt_note"/>
6669
<field name="message_type">notification</field>
6770
<field eval="DateTime.today() + relativedelta(months=-3, days=-7, minutes=52)" name="date"/>

addons/im_livechat/demo/im_livechat_channel/im_livechat_session_9.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
<record id="livechat_channel_session_9_message_1" model="mail.message">
2727
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_9_guest"/>
28+
<field name="author_id"/>
2829
<field name="record_name">Visitor</field>
2930
<field name="date" eval="datetime.now() - timedelta(days=1)"/>
3031
<field name="create_date" eval="datetime.now() - timedelta(days=1)"/>
@@ -48,6 +49,7 @@
4849
</record>
4950
<record id="livechat_channel_session_9_message_3" model="mail.message">
5051
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_9_guest"/>
52+
<field name="author_id"/>
5153
<field name="record_name">Visitor</field>
5254
<field name="date" eval="datetime.now() - timedelta(days=1, seconds=-25)"/>
5355
<field name="create_date" eval="datetime.now() - timedelta(days=1, seconds=-25)"/>
@@ -71,6 +73,7 @@
7173
</record>
7274
<record id="livechat_channel_session_9_message_5" model="mail.message">
7375
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_9_guest"/>
76+
<field name="author_id"/>
7477
<field name="record_name">Visitor</field>
7578
<field name="date" eval="datetime.now() - timedelta(days=1, seconds=-42)"/>
7679
<field name="create_date" eval="datetime.now() - timedelta(days=1, seconds=-42)"/>
@@ -83,6 +86,7 @@
8386
</record>
8487
<record id="livechat_channel_session_9_message_6" model="mail.message">
8588
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_9_guest"/>
89+
<field name="author_id"/>
8690
<field name="record_name">Visitor</field>
8791
<field name="date" eval="datetime.now() - timedelta(days=1, seconds=-53)"/>
8892
<field name="create_date" eval="datetime.now() - timedelta(days=1, seconds=-53)"/>
@@ -97,6 +101,7 @@
97101
<field name="model">discuss.channel</field>
98102
<field name="res_id" ref="im_livechat.livechat_channel_session_9"/>
99103
<field name="author_guest_id" ref="im_livechat.livechat_channel_session_9_guest"/>
104+
<field name="author_id"/>
100105
<field name="subtype_id" ref="mail.mt_note"/>
101106
<field name="message_type">notification</field>
102107
<field eval="datetime.now() - timedelta(days=1, seconds=-60)" name="date"/>

0 commit comments

Comments
 (0)