[IMP] sales: add pricelist to loyalty prgms #10064
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ksc-odoo
force-pushed
the
17.0-sales-loyalty-pricelist-ksc
branch
2 times, most recently
from
376753c to
ef00aa0
Compare
|
Hey, @larm-odoo -- this one is ready for a Peer Review from you whenever you get a chance. Thanks! 👍 |
larm-odoo
approved these changes
Jul 3, 2024
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
ksc-odoo
force-pushed
the
17.0-sales-loyalty-pricelist-ksc
branch
from
ef00aa0 to
189058b
Compare
|
Thanks for the always helpful feedback, @larm-odoo -- I made the necessary adjustments, and believe this one is now ready for Final Review, @StraubCreative 👍 (whenever you get a chance) |
StraubCreative
force-pushed
the
17.0-sales-loyalty-pricelist-ksc
branch
from
189058b to
7276e13
Compare
|
Fresh rebase on 7276e13 to fix ci/codeowner_coverage error |
ksc-odoo
force-pushed
the
17.0-sales-loyalty-pricelist-ksc
branch
from
7276e13 to
7696b7b
Compare
|
After giving this another pass (per our discussion), I believe this one is now "officially" ready for a Final Review, @StraubCreative (whenever you get a chance). Thanks! 🙏 |
StraubCreative
approved these changes
Aug 6, 2024
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is focused on adding important/updated information about how Loyalty Programs can be applied to a specific Pricelist in v17 -- as detailed in the most recent release notes. (this PR was requested by VPD)
It also updates/adds necessary screenshots, updates some definitions, and reorganizes some elements to be in the same order they appear on the UI for easier readability. It also adds a necessary mention about the addition of the Start and End Date fields that are now present on the program form.
PROJECT TASK: https://www.odoo.com/odoo/project/3835/tasks/4033461?cids=3