-
Notifications
You must be signed in to change notification settings - Fork 10.1k
[ADD] Fleet: new accident management doc #10263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bda4dce
to
1051159
Compare
Hi @Felicious - this is ready for a first-round review If you want to use a DB while you look/check the doc, I put the details for my custom DB in the project task card (above). If not, you won't be able to completely follow- you can make the accident service log but not see any data. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMAZING job with this PR, @larm-odoo !
I'm impressed-- this doc covers so many different situations, reports, and views while being clear, straight-to-the-point, and detailed. I barely had any suggestions to make, and they're all totally optional rewording suggestions.
It was more fun than usual to review your doc 😊 Incredible work here!
1051159
to
26cda51
Compare
This is ready for a final review, @ksc-odoo - thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @larm-odoo -- just finished my Final Review of this PR. Great work. There are a decent amount of comments/feedback/etc. that requires your attention. So, once you implement the necessary changes, tag me again for another quick look. Thanks 👍
26cda51
to
9c999f7
Compare
Hi @ksc-odoo - thank you for the thorough review! This is ready for another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the revisions, @larm-odoo -- Only a few more, super-minor comments that require your attention. Once you take care of those, feel free to move it to the next stage. Thanks! 👍
9c999f7
to
252c844
Compare
Hi @samueljlieber - this is ready for you! |
Hi @StraubCreative - tagging you since I am supposed to ping you, not Sam! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @larm-odoo! Awesome job on this new Fleet doc on managing accidents. Everything looks great, Approving with just a couple super small changes 👍
Thank you for your work!
.....
@robodoo delegate=larm-odoo
252c844
to
02eb025
Compare
@robodoo r+ |
This PR is already reviewed, reviewing it again is useless. |
Gained some tips and ideas from Cecile for managing accidents in fleet. No documentation regarding accidents currently exists.
Project Task card for this PR.