Skip to content

Conversation

larm-odoo
Copy link
Contributor

Gained some tips and ideas from Cecile for managing accidents in fleet. ​No documentation regarding accidents currently exists.

Project Task card for this PR.

@robodoo
Copy link
Collaborator

robodoo commented Jul 18, 2024

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team July 18, 2024 19:22
@larm-odoo larm-odoo marked this pull request as draft July 18, 2024 19:29
@larm-odoo larm-odoo force-pushed the 17.0-fleet-accident-tracking-larm branch from bda4dce to 1051159 Compare July 22, 2024 20:31
@larm-odoo larm-odoo marked this pull request as ready for review July 22, 2024 20:31
@larm-odoo larm-odoo requested a review from a team July 22, 2024 20:32
@larm-odoo
Copy link
Contributor Author

Hi @Felicious - this is ready for a first-round review If you want to use a DB while you look/check the doc, I put the details for my custom DB in the project task card (above). If not, you won't be able to completely follow- you can make the accident service log but not see any data. Thank you!

@larm-odoo larm-odoo added the 5 label Jul 23, 2024
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING job with this PR, @larm-odoo !

I'm impressed-- this doc covers so many different situations, reports, and views while being clear, straight-to-the-point, and detailed. I barely had any suggestions to make, and they're all totally optional rewording suggestions.

It was more fun than usual to review your doc 😊 Incredible work here!

@larm-odoo larm-odoo force-pushed the 17.0-fleet-accident-tracking-larm branch from 1051159 to 26cda51 Compare July 24, 2024 14:43
@larm-odoo larm-odoo requested a review from a team July 24, 2024 14:43
@larm-odoo
Copy link
Contributor Author

This is ready for a final review, @ksc-odoo - thank you!

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @larm-odoo -- just finished my Final Review of this PR. Great work. There are a decent amount of comments/feedback/etc. that requires your attention. So, once you implement the necessary changes, tag me again for another quick look. Thanks 👍

@larm-odoo larm-odoo force-pushed the 17.0-fleet-accident-tracking-larm branch from 26cda51 to 9c999f7 Compare July 24, 2024 20:14
@larm-odoo larm-odoo requested a review from ksc-odoo July 24, 2024 20:14
@larm-odoo
Copy link
Contributor Author

Hi @ksc-odoo - thank you for the thorough review! This is ready for another look.

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the revisions, @larm-odoo -- Only a few more, super-minor comments that require your attention. Once you take care of those, feel free to move it to the next stage. Thanks! 👍

@larm-odoo larm-odoo force-pushed the 17.0-fleet-accident-tracking-larm branch from 9c999f7 to 252c844 Compare July 25, 2024 13:51
@larm-odoo larm-odoo requested a review from a team July 25, 2024 13:52
@larm-odoo
Copy link
Contributor Author

Hi @samueljlieber - this is ready for you!

@larm-odoo
Copy link
Contributor Author

Hi @StraubCreative - tagging you since I am supposed to ping you, not Sam!

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larm-odoo! Awesome job on this new Fleet doc on managing accidents. Everything looks great, Approving with just a couple super small changes 👍

Thank you for your work!
.....
@robodoo delegate=larm-odoo

@larm-odoo larm-odoo force-pushed the 17.0-fleet-accident-tracking-larm branch from 252c844 to 02eb025 Compare July 30, 2024 13:13
@larm-odoo
Copy link
Contributor Author

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Jul 30, 2024

This PR is already reviewed, reviewing it again is useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants