[ADD] Expenses: new log expenses doc #10322
Conversation
|
|
|
Hi @hojo-odoo - this is ready for a first round review. Thanks! |
There was a problem hiding this comment.
Hey @larm-odoo,
Nice job on this doc. Feel free to move it to the next round of review, once you take a look at my comments.
Thanks,
John
larm-odoo
force-pushed
the
17.0-expenses-new-log-expenses-doc-larm
branch
from
d14a97d to
8aa01c0
Compare
|
Hi @ksc-odoo, this is ready for a final review. Thanks! |
There was a problem hiding this comment.
hey @larm-odoo -- just finished my Final Review. There are a decent amount of comments/feedback that require your attention. Once you implement the necessary changes/adjustments, and feel like it's ready, you can move it to Tech Review. Thanks!
|
Thank you @ksc-odoo for the review! Just an FYI, I did not put in the few suggestions for expenses.rst, since it will cause multiple merge conflicts, and I will be editing that doc once all these sub-docs have been removed and merged. Just wanted to explain in case you saw those differences! |
larm-odoo
force-pushed
the
17.0-expenses-new-log-expenses-doc-larm
branch
from
8aa01c0 to
f9d9dc8
Compare
larm-odoo
force-pushed
the
17.0-expenses-new-log-expenses-doc-larm
branch
from
f9d9dc8 to
ede6619
Compare
|
Hi @samueljlieber - this is ready for a tech review =) |
|
Hi @larm-odoo, this PR is looking good but before I fully review lets rebase after #10360 is merged :) |
samueljlieber
force-pushed
the
17.0-expenses-new-log-expenses-doc-larm
branch
from
ede6619 to
15b9a66
Compare
|
Resolved merge conflict in 15b9a66 |
There was a problem hiding this comment.
Looks good to me @larm-odoo! Thank you :)
.....
@robodoo r+
Original Expenses doc too long, breaking off the logging expenses section into its own doc, and making necessary updates to version 17 (original was written for 16).
Project task card for this PR.