[IMP] barcode: add nomenclature example #10323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @ksc-odoo ! This PR is ready for your first round of peer review (: |
Felicious
force-pushed
the
16.0-barcode-nomenclature-feku
branch
from
c31a64f to
1658bf9
Compare
ksc-odoo
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
hey @Felicious -- just finished my Peer Review of this PR. Great work! Just a small collection of feedback that requires your attention. Once you implement the necessary changes, feel free to move this to the next stage. Thanks! 👍
content/applications/inventory_and_mrp/barcode/operations/barcode_nomenclature.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/barcode_nomenclature.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/barcode_nomenclature.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/barcode_nomenclature.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/barcode_nomenclature.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/barcode_nomenclature.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/barcode_nomenclature.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/barcode_nomenclature.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/barcode_nomenclature.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/barcode_nomenclature.rst
Show resolved
Hide resolved
Felicious
force-pushed
the
16.0-barcode-nomenclature-feku
branch
2 times, most recently
from
a9baebe to
e6c26d8
Compare
|
@odoo/us-doc-review Hi @StraubCreative ! This PR has been approved by KC, and is ready for your QA review 😺 |
samueljlieber
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Hi @Felicious, awesome job on this barcode doc! This is a huge improvement and I like how many examples you provided to help explain the digit patterns!
Approving with a couple really small fixes/suggestions, thank you for your work!
(also bumping this to 3pts because the overall doc was improved and expanded upon)
...
@robodoo delegate=Felicious
content/applications/inventory_and_mrp/barcode/operations/barcode_nomenclature.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/barcode_nomenclature.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
Felicious
force-pushed
the
16.0-barcode-nomenclature-feku
branch
from
4e3ce12 to
b8159c8
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jul 29, 2024
closes #10323 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Fwport: yes