[ADD] Expenses: reimburse employees doc #10393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
larm-odoo
force-pushed
the
17.0-expenses-reimburse-employees-larm
branch
from
505c47c to
07ab3f1
Compare
|
Hi @hojo-odoo - this is ready for a first-round review! |
larm-odoo
force-pushed
the
17.0-expenses-reimburse-employees-larm
branch
from
07ab3f1 to
011840a
Compare
larm-odoo
force-pushed
the
17.0-expenses-reimburse-employees-larm
branch
2 times, most recently
from
5624965 to
a349016
Compare
ksc-odoo
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
hey @larm-odoo -- just finished my Final Review. Once you implement the necessary changes/modifications, feel free to tag this for Tech Review. Thanks.
larm-odoo
force-pushed
the
17.0-expenses-reimburse-employees-larm
branch
from
a349016 to
261d4b2
Compare
larm-odoo
force-pushed
the
17.0-expenses-reimburse-employees-larm
branch
2 times, most recently
from
06e3c8f to
5700c5d
Compare
|
Finally, all cleaned up and conflicts fixed for a final review, @samueljlieber! |
samueljlieber
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Hi @larm-odoo, nice job on this Expenses PR to break out the Reimburse content to its own doc.
Approving with two quick mandatory image fixes, please implement these before merge, thanks!
.....
@robodoo delegate=larm-odoo
larm-odoo
force-pushed
the
17.0-expenses-reimburse-employees-larm
branch
from
5700c5d to
1cdf771
Compare
|
@robodoo r+ |
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Expenses doc too long, breaking off the reimbursing expenses to accounting section into its own doc, and making necessary updates to version 17 (original was written for 16). Also updating per new doc guidelines.
Project task card for this PR.