Skip to content

Conversation

auva-odoo
Copy link
Contributor

@auva-odoo auva-odoo commented Aug 9, 2024

task-3709518

16.0: Keep Icons section from existing version

@robodoo
Copy link
Collaborator

robodoo commented Aug 9, 2024

Pull request status dashboard

@auva-odoo auva-odoo force-pushed the 15.0-doc-guidelines-auva branch from b2d8f4f to 71985d7 Compare August 13, 2024 09:16
@auva-odoo
Copy link
Contributor Author

Hello @dade-odoo and @xpl-odoo, here is a first draft of the updated documentation guidelines. When you get a chance, could you please take a look and let me know if everything looks good to yoy and if I missed anything? Thank you guys!

Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job Audrey! I have mostly commented on parts you didn't edit, and most comments are suggestions only :)

@auva-odoo auva-odoo force-pushed the 15.0-doc-guidelines-auva branch from 71985d7 to dfe9476 Compare August 23, 2024 14:17
Copy link
Contributor Author

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xpl-odoo @dade-odoo I force-pushed most of the changes but I still have a few I want to make. I'll let you know when it's ready for review (again) 🙂


.. _contributing/documentation/first-contribution:
.. _contributing-documentation-first-contribution:

Make your first contribution
Copy link
Contributor Author

@auva-odoo auva-odoo Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this one but noticed that we actually have a bunch of these in the rst_guidelines as well 🙈 They're not so easy to change though as we made the actually instructions into headings. However, you have solid point when you say we should respect the guidelines in the guidelines. What do you think?

Edited: I changed them

@auva-odoo auva-odoo force-pushed the 15.0-doc-guidelines-auva branch from dfe9476 to 98bf33c Compare August 26, 2024 08:12
@auva-odoo
Copy link
Contributor Author

auva-odoo commented Aug 26, 2024

@xpl-odoo @dade-odoo ready for you to review (again) 🙂

@auva-odoo auva-odoo force-pushed the 15.0-doc-guidelines-auva branch from 98bf33c to 220baf4 Compare August 26, 2024 08:33
Copy link
Contributor

@dade-odoo dade-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auva-odoo thanks for your patience! Happy to discuss any of the points further with you :)

@auva-odoo auva-odoo force-pushed the 15.0-doc-guidelines-auva branch from 220baf4 to a7ff8d8 Compare August 29, 2024 13:57
@auva-odoo auva-odoo force-pushed the 15.0-doc-guidelines-auva branch 2 times, most recently from 16c8d52 to ecaa120 Compare August 30, 2024 12:36
@auva-odoo auva-odoo marked this pull request as ready for review September 2, 2024 07:06
@C3POdoo C3POdoo requested a review from a team September 2, 2024 07:07
@xpl-odoo xpl-odoo removed the request for review from a team September 2, 2024 07:39
@auva-odoo
Copy link
Contributor Author

Hi @StraubCreative I've made the changes to the documentation guidelines as discussed (through Dallas). I'd appreciate it if you could take a look and share your thoughts 🙂. Thank you!

@xpl-odoo xpl-odoo force-pushed the 15.0-doc-guidelines-auva branch from ecaa120 to 6f778ac Compare September 2, 2024 11:21
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @auva-odoo

This is so great to see, thank you for putting this together 🙏

I still have more to look at after the Content guidelines > Capitalization section, however here are some comments below for your consideration. I hope you find them helpful and please let me know if you want to discuss anything more in particular.

Thanks again and talk more soon!

@auva-odoo auva-odoo force-pushed the 15.0-doc-guidelines-auva branch from 6f778ac to 3841ee4 Compare September 10, 2024 13:05
@auva-odoo
Copy link
Contributor Author

Hi @StraubCreative, thank you so much for taking the time to start reviewing this PR! 🙏 I've already implemented most of your initial suggestions. Do you think you’ll have time to go through the rest by the end of September? We’re aiming to have the updated guidelines live after OXP, and your input would be much appreciated 🙂

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @auva-odoo

From where I left off, I think the rest of the doc looks good. I just have a few optional suggestions for your consideration here, otherwise I think we're good to go! 🚀

Thank you!

@auva-odoo auva-odoo force-pushed the 15.0-doc-guidelines-auva branch from 3841ee4 to 1412561 Compare September 13, 2024 09:09
@auva-odoo
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants