Skip to content

[IMP] iot: refactor and update configuration documentation #11518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] iot: refactor and update configuration documentation #11518

wants to merge 1 commit into from

Conversation

auva-odoo
Copy link
Contributor

@auva-odoo auva-odoo commented Dec 3, 2024 •
edited
Loading

Restructure and update the IoT documentation.
(The doc pages in the Devices section will be updated in a separate PR)

@robodoo
Copy link
Collaborator

robodoo commented Dec 3, 2024

Pull request status dashboard

@auva-odoo auva-odoo force-pushed the 17.0-iot-restructure-auva branch 2 times, most recently from a70024a to fc3b291 Compare December 6, 2024 15:19
@auva-odoo auva-odoo force-pushed the 17.0-iot-restructure-auva branch 4 times, most recently from fbbc95e to 5f09767 Compare December 24, 2024 10:51
@auva-odoo
Copy link
Contributor Author

auva-odoo commented Dec 24, 2024 •
edited
Loading

@lse-odoo This PR is ready for your review! 🎉 I've implemented the changes we discussed. Regarding the structure of the updating_iot.rst file, I've kept it as we had it the last time we talked, as I believe it still reflects the current way things work. However, if there's anything that needs correction/adjustment, I'm happy to revise it of course 🤗
(and I know changes are coming but we'll revisit the structure once those are in place).

Thank you so much for your time and your help on this, I appreciate it very much!

lse-odoo
lse-odoo reviewed Dec 25, 2024
View reviewed changes
Copy link
Contributor

@lse-odoo lse-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review part 1 / ?

Overall a huge improvement, my comments are mostly nitpicking. Thanks for your work!

lse-odoo
lse-odoo reviewed Dec 26, 2024
View reviewed changes
Copy link
Contributor

@lse-odoo lse-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review part 2/?

lse-odoo
lse-odoo requested changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@lse-odoo lse-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't access the "IoT system connection to Odoo"
image
probably wrong toc or something

@auva-odoo auva-odoo force-pushed the 17.0-iot-restructure-auva branch from 5f09767 to 78c5fa7 Compare January 2, 2025 14:39
lse-odoo
lse-odoo reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@lse-odoo lse-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review part 3/3

impressive work, the screenshots are perfect and the explanations super clear

@lse-odoo lse-odoo mentioned this pull request Jan 3, 2025
Closed
@auva-odoo auva-odoo force-pushed the 17.0-iot-restructure-auva branch 2 times, most recently from 7c08a95 to 9a58c03 Compare January 9, 2025 08:25
@auva-odoo auva-odoo force-pushed the 17.0-iot-restructure-auva branch from 9a58c03 to c84d90c Compare January 20, 2025 08:23
@auva-odoo
Copy link
Contributor Author

@lse-odoo this is ready for another look. I implemented the changes we talked about during our last meeting and the latest updates made to the updating process. Could you please (at least) check that everything is ok in the updating_iot.rst file? Thank you 🙂 (we're almost there I think!! 🤞)

@auva-odoo auva-odoo requested a review from xpl-odoo January 20, 2025 09:21
xpl-odoo
xpl-odoo reviewed Jan 21, 2025
View reviewed changes
lse-odoo
lse-odoo reviewed Jan 21, 2025
View reviewed changes
@auva-odoo auva-odoo force-pushed the 17.0-iot-restructure-auva branch 2 times, most recently from 8513ea1 to 1862011 Compare January 27, 2025 08:09
@lse-odoo
Copy link
Contributor

@robodoo retry

@robodoo
Copy link
Collaborator

robodoo commented Jan 27, 2025

I'm sorry, @lse-odoo. I'm afraid I can't do that.

@lse-odoo
Copy link
Contributor

@robodoo help

@robodoo
Copy link
Collaborator

robodoo commented Jan 27, 2025

Currently available commands for @lse-odoo:

command
help displays this help

Note: this help text is dynamic and will change with the state of the PR.

@xpl-odoo xpl-odoo marked this pull request as ready for review January 27, 2025 08:22
@C3POdoo C3POdoo requested review from a team January 27, 2025 08:24
@C3POdoo C3POdoo requested a review from a team January 27, 2025 08:24
@xpl-odoo
Copy link
Contributor

@robodoo retry

(FYI, even if this knowledge isn't that useful as you don't have r+ rights: https://github.com/odoo/odoo/wiki/Mergebot#available-commands)

@xpl-odoo xpl-odoo removed request for a team January 27, 2025 08:34
lse-odoo
lse-odoo reviewed Jan 27, 2025
View reviewed changes
@auva-odoo auva-odoo force-pushed the 17.0-iot-restructure-auva branch from 1862011 to 9fbbf9d Compare January 28, 2025 08:15
xpl-odoo
xpl-odoo reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the previous author's:

JPEG to be converted and compressed:
iot/devices/measurement_tool/measurement-tool.jpeg

Uncompressed:
iot/devices/camera/control-point-device.png
iot/troubleshooting/barcode-scanner-settings.png
iot/troubleshooting/printer-status.png

In any case, amazing job @auva-odoo and @lse-odoo :)

@auva-odoo
[IMP] iot: refactor and update configuration documentation
831dfc8 
Restructure and update the iot documentation
@auva-odoo auva-odoo force-pushed the 17.0-iot-restructure-auva branch from 9fbbf9d to 831dfc8 Compare January 30, 2025 10:34
@auva-odoo
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Jan 30, 2025
@auva-odoo
[IMP] iot: refactor and update configuration documentation
7f49e8c 
Restructure and update the iot documentation

closes #11518

Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
robodoo pushed a commit that referenced this pull request Jan 30, 2025
@auva-odoo
[IMP] iot: refactor and update configuration documentation
43e244e 
Restructure and update the iot documentation

closes #11518

Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
@robodoo robodoo closed this Jan 30, 2025
This was referenced Jan 30, 2025
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpl-odoo xpl-odoo xpl-odoo left review comments

@lse-odoo lse-odoo lse-odoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@auva-odoo @robodoo @lse-odoo @xpl-odoo