[IMP] account_reports: Unambiguous cross_report aggregations #11747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
afma-odoo
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Thanks @lost-odoo for the update. Can you just capitalize "ID"?
Thank you!
content/applications/finance/accounting/reporting/customize.rst
Outdated
Show resolved
Hide resolved
lost-odoo
force-pushed
the
master-cross-report-imp-lost
branch
from
748c8dd to
7561b20
Compare
auva-odoo
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Thanks @lost-odoo and @afma-odoo for your work!
@robodoo delegate+
lost-odoo
force-pushed
the
master-cross-report-imp-lost
branch
from
7561b20 to
b14f8a8
Compare
lost-odoo
force-pushed
the
master-cross-report-imp-lost
branch
2 times, most recently
from
608a0c2 to
db4a1e1
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 19, 2025
Before this commit, when using cross_report subformula it would search for a report that has an line with this code. We had to ensure there was no duplicate codes and so it was difficult to maintain. Now, when we use a cross_report subformula, we need to explicitly target the report from where the code is from. task-4457667 closes #11747 Related: odoo/odoo#193106 Related: odoo/enterprise#76845 Signed-off-by: Logan Staelens (lost) <lost@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Feb 19, 2025
Before this commit, when using cross_report subformula it would search for a report that has an line with this code. We had to ensure there was no duplicate codes and so it was difficult to maintain. Now, when we use a cross_report subformula, we need to explicitly target the report from where the code is from. task-4457667 closes #11747 Related: odoo/odoo#193106 Related: odoo/enterprise#76845 Signed-off-by: Logan Staelens (lost) <lost@odoo.com>
|
@robodoo r- |
|
I'm sorry, @hupo-odoo. I'm afraid I can't do that. |
|
@lost-odoo linked pull request(s) odoo/enterprise#76845, odoo/odoo#193106 not ready. Linked PRs are not staged until all of them are ready. |
Before this commit, when using cross_report subformula it would search for a report that has an line with this code. We had to ensure there was no duplicate codes and so it was difficult to maintain. Now, when we use a cross_report subformula, we need to explicitly target the report from where the code is from. task-4457667
lost-odoo
force-pushed
the
master-cross-report-imp-lost
branch
from
db4a1e1 to
a349b88
Compare
|
@robodoo r+ |
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Feb 20, 2025
Before this commit, when using cross_report subformula it would search for a report that has an line with this code. We had to ensure there was no duplicate codes and so it was difficult to maintain. Now, when we use a cross_report subformula, we need to explicitly target the report from where the code is from. task-4457667 closes #193106 Related: odoo/enterprise#76845 Related: odoo/documentation#11747 Signed-off-by: Hugo Poncelet (hupo) <hupo@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Feb 20, 2025
Before this commit, when using cross_report subformula it would search for a report that has an line with this code. We had to ensure there was no duplicate codes and so it was difficult to maintain. Now, when we use a cross_report subformula, we need to explicitly target the report from where the code is from. task-4457667 closes #11747 Related: odoo/odoo#193106 Related: odoo/enterprise#76845 Signed-off-by: Logan Staelens (lost) <lost@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when using cross_report subformula it would search for a report that has an line with this code. We had to ensure there was no duplicate codes and so it was difficult to maintain.
Now, when we use a cross_report subformula, we need to explicitly target the report from where the code is from.
task-4457667