Skip to content

Conversation

justinmallette
Copy link
Contributor

Updated images to new style standards. Fixed UI discrepancies.

@robodoo
Copy link
Collaborator

robodoo commented Feb 21, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team February 21, 2025 22:22
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @justinmallette !

I can tell you took the time to go through our style guide carefully—great work! 😊 The improvements you made look solid, and the updated images are a great touch. The only reason I’m pushing this draft back is for the icon usage.

All my other suggestions are purely optional—just some rewording tweaks to make the doc even more concise and a few pointers to help you get more familiar with our team's guidelines on guilabel and menuselection tags. Once you've had a chance to review and implement any changes, tag me for a second review!

One small housekeeping note—under the Labels section of the PR, make sure to assign a point value of 2 so your work is properly counted in our reporting software.

You're doing amazing, and congrats on setting the record for the fastest first PR on the team! 🚀 Hope all that waiting to install the repo, Vale, and everything else was worth it. 😆

@justinmallette justinmallette force-pushed the 18.0-manage-lost-opportunities-juma branch 3 times, most recently from 6fbd2e2 to 96e5d59 Compare February 24, 2025 18:13
@justinmallette
Copy link
Contributor Author

@Felicious Made all the requested changes. Ready for another review

@justinmallette justinmallette self-assigned this Feb 24, 2025
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @justinmallette !

The content looks solid—I just have a few small RST formatting tweaks. Once you've made those updates, tag me again, and I should be able to approve it after a quick ~5 min pass! 🎉

Also, this PR is worth 2 points! If the task said 1, I'm re-evaluating it to 2 points, because you've done a number of changes to update the content and accuracy to align with the 18.0 UI and out latest standards!

@justinmallette justinmallette added 2 and removed 1 labels Feb 24, 2025
@justinmallette justinmallette force-pushed the 18.0-manage-lost-opportunities-juma branch from 57b9258 to fdf9b84 Compare February 24, 2025 21:30
@justinmallette
Copy link
Contributor Author

@Felicious Ready for another review

@Felicious
Copy link
Contributor

Felicious commented Feb 24, 2025

Great job fixing the icon descriptors and backticks! We just need to find an alternative rewrapping extension for you 😊

(Oh and those darn kit changes are still there 😭 )

@justinmallette justinmallette force-pushed the 18.0-manage-lost-opportunities-juma branch 2 times, most recently from 6ae66c8 to 95172f8 Compare February 25, 2025 16:50
@justinmallette
Copy link
Contributor Author

justinmallette commented Feb 25, 2025

LMK if the text is wrapped! I think I got a newer version of the extension to work (and those kit changes are reverted :))

@justinmallette justinmallette force-pushed the 18.0-manage-lost-opportunities-juma branch 3 times, most recently from 425439e to f1572cd Compare February 25, 2025 18:08
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job, @justinmallette !

Everything works as expected, and the instructions are accurate and align with the 18.0 UI! You've also made great improvements for brevity and readability—nice work! 🎉

After taking a look at my optional comments, feel free to tag @StraubCreative for final review!

@justinmallette justinmallette force-pushed the 18.0-manage-lost-opportunities-juma branch 2 times, most recently from da40b24 to 78d83f9 Compare February 25, 2025 22:52
@justinmallette
Copy link
Contributor Author

@StraubCreative Ready for your review

@StraubCreative StraubCreative self-requested a review February 26, 2025 18:59
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @justinmallette

Pausing here after a few comments— a lot of these changes didn't need to be made as they'd fall under superficial elements of "craft" in our quality matrix.

In our guidelines we explicitly say that rewrites need to having compelling reasons behind them, which I'm not seeing here so far (correct me if I'm missing something!).

My suggestion is to revert back all of superficial changes (either manual c/p + force push or git reset --hard [commit_hash]) and keep only the necessary ones that center around adding or updating context, fixing errors or inaccurate information, deepening product education, etc. (not writerly things like small word choices).

Framing the feedback into actionable learning:

  • discover how to quickly revert changes in Git
    • learn how to revert changes in batch across multiple PRs
  • (re)familiarize yourself with the team guidelines around rewrites
  • reflect on the cost of speed vs. quality, and calibrate accordingly for higher and more precise impact in submitted work...many PRs with the same issue (e.g. missing conjunctions, unnecessary rewrites, etc.) means time gets wasted in a compounding way due to unnecessary review(s) and discussion, duplicate or redundant work, having to redo or fix mistake, etc.

Hope this helps explain the logic of my change requests 🙏
Please let me know if you have any questions otherwise I can take another look after (click the 🔄 gear next to my u/n in Reviewers box).

Comment on lines 26 to 27
choose an existing lost reason. If none of these are appropriate, create a new one by entering it
into the :guilabel:`Lost Reason` field, then select :guilabel:`Create`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this sentence and others are missing "and" conjunctions?
"If" statements ideally follow with a quick "then" consequence.
Another example of a sentence that did not need to be rewritten.

Suggested change
choose an existing lost reason. If none of these are appropriate, create a new one by entering it
into the :guilabel:`Lost Reason` field, then select :guilabel:`Create`.
choose an existing lost reason. If none of these are appropriate, then create a new one by entering it
into the :guilabel:`Lost Reason` field, and then clicking :guilabel:`Create`.

@justinmallette justinmallette force-pushed the 18.0-manage-lost-opportunities-juma branch 2 times, most recently from d9fd056 to b49b8f9 Compare February 26, 2025 21:43
@justinmallette justinmallette force-pushed the 18.0-manage-lost-opportunities-juma branch from b49b8f9 to c0e1c31 Compare February 26, 2025 21:53
@justinmallette
Copy link
Contributor Author

@StraubCreative I've taken another look through the file, and I believe its ready for another look from you. Please let me know if there's still something you're looking for but not seeing in this latest version

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @justinmallette
Approving with a few comments around UI terminology
Can pass to Sam when you've taken a look, thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opportunity here for cleaner crop, highlight the selection in the Filters column, and show how the filter looks when it's active in the search bar.

Can use this if you like which I took at 120% zoom (needs resize first and then compressed)
image

@justinmallette justinmallette force-pushed the 18.0-manage-lost-opportunities-juma branch 3 times, most recently from 28cdb7b to a899e28 Compare February 27, 2025 19:46
@justinmallette
Copy link
Contributor Author

@samueljlieber Ready for a tech review!

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @justinmallette! Nice work on this improvement PR! Your changes look great to me. I am approving with two small fixes. Please address these before merge.
..
@robodoo delegate=justinmallette

@justinmallette justinmallette force-pushed the 18.0-manage-lost-opportunities-juma branch from fcae73b to efdf884 Compare February 28, 2025 15:36
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
@justinmallette justinmallette force-pushed the 18.0-manage-lost-opportunities-juma branch from efdf884 to 50c2770 Compare February 28, 2025 15:47
@justinmallette
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Feb 28, 2025
closes #12151

Signed-off-by: Justin Mallette (juma) <juma@odoo.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
robodoo pushed a commit that referenced this pull request Feb 28, 2025
closes #12151

Signed-off-by: Justin Mallette (juma) <juma@odoo.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
@robodoo robodoo closed this in ee19be8 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants