-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[ADD] hr: Belgium payroll localization #12181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@odoo/payroll-doc-review Hi ! If you got some time, would be cool to have a review over here. The content is mostly about Belgian Payroll localization (other countries are planned in new PRs). If I understand correctly, you're from US, so don't bother about the content but more about the display please. We have new customers using Belgian payroll complaining about the lack of documentation, so this is supposed to be merged quickly. Have a nice day, Yannick. |
e5143a4
to
8615bbb
Compare
@robodoo rebase-ff |
Merge method set to rebase and fast-forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content additions are great here!
Thank you for the impressive contribution @tivisse.
Approving and passing to technical review to catch anything glaring for RST, formatting, etc. and then merge.
cc: @samueljlieber
8615bbb
to
bf083fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tivisse!
Thank you for your work on this seriously impressive contribution :)
Due to the size of this PR, I hope you don't mind I made a commit with a number of edits regarding RST formatting and display. Details of the changes can be found here, and a summary below:
- Updated RST to follow the Documentation content and RST guidelines
- Resized all images to be <= 933px and compressed with pngquant and removed any images where the written instruction was sufficient
- Updated the
:math:
directives to format text a little clearer - Updated custom anchors to follow this convention:
_payroll/l10n_be/heading:
I am going to delegate merge to you, if you approve of my changes feel free to +.
Thank you for your work!
@robodoo delegate=tivisse
Hello @StraubCreative @samueljlieber Thanks a lot for your reviews and updates on the PR. I've tried to follow the guidelines, but indeed your contribution was very welcome @samueljlieber Have a wonderful end of the week :) @robodoo r+ |
Part-of: #12181 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Part-of: #12181 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Part-of: #12181 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
…page Part-of: #12181 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
No description provided.