Skip to content

[ADD] hr: Belgium payroll localization #12181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

tivisse
Copy link
Collaborator

@tivisse tivisse commented Feb 25, 2025

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented Feb 25, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team February 25, 2025 18:25
@tivisse
Copy link
Collaborator Author

tivisse commented Feb 27, 2025

@odoo/payroll-doc-review Hi ! If you got some time, would be cool to have a review over here.

The content is mostly about Belgian Payroll localization (other countries are planned in new PRs).

If I understand correctly, you're from US, so don't bother about the content but more about the display please.

We have new customers using Belgian payroll complaining about the lack of documentation, so this is supposed to be merged quickly.

Have a nice day,

Yannick.

@tivisse tivisse force-pushed the 18.0-belgium-payroll-yti branch 2 times, most recently from e5143a4 to 8615bbb Compare March 4, 2025 15:48
@tivisse
Copy link
Collaborator Author

tivisse commented Mar 4, 2025

@robodoo rebase-ff

@robodoo
Copy link
Collaborator

robodoo commented Mar 4, 2025

Merge method set to rebase and fast-forward.

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content additions are great here!
Thank you for the impressive contribution @tivisse.

Approving and passing to technical review to catch anything glaring for RST, formatting, etc. and then merge.

cc: @samueljlieber

@samueljlieber samueljlieber force-pushed the 18.0-belgium-payroll-yti branch from 8615bbb to bf083fa Compare March 5, 2025 21:53
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tivisse!
Thank you for your work on this seriously impressive contribution :)

Due to the size of this PR, I hope you don't mind I made a commit with a number of edits regarding RST formatting and display. Details of the changes can be found here, and a summary below:

  • Updated RST to follow the Documentation content and RST guidelines
  • Resized all images to be <= 933px and compressed with pngquant and removed any images where the written instruction was sufficient
    • This reduced the page weight from 11.5MB
      Screenshot 2025-03-05 at 4 54 45 PM
      To 5.6MB
      Screenshot 2025-03-05 at 5 12 29 PM
  • Updated the :math: directives to format text a little clearer
  • Updated custom anchors to follow this convention: _payroll/l10n_be/heading:

I am going to delegate merge to you, if you approve of my changes feel free to +.

Thank you for your work!

@robodoo delegate=tivisse

@tivisse
Copy link
Collaborator Author

tivisse commented Mar 6, 2025

Hello @StraubCreative @samueljlieber

Thanks a lot for your reviews and updates on the PR. I've tried to follow the guidelines, but indeed your contribution was very welcome @samueljlieber

Have a wonderful end of the week :)

@robodoo r+

robodoo pushed a commit that referenced this pull request Mar 6, 2025
Part-of: #12181
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
robodoo pushed a commit that referenced this pull request Mar 6, 2025
Part-of: #12181
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
robodoo pushed a commit that referenced this pull request Mar 6, 2025
Part-of: #12181
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
robodoo pushed a commit that referenced this pull request Mar 6, 2025
…page

Part-of: #12181
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
@robodoo robodoo closed this in 52130bc Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants