Skip to content

Conversation

sclo-odoo
Copy link
Contributor

@sclo-odoo sclo-odoo commented Apr 17, 2025

Adding the NFC-e configurations and workflows to the user guide.

Suggestion is to add the separately from the other flows, Like the "Vendor Bill" flow, just because it's specificity

Documentation: https://docs.google.com/document/d/1s-OvUfxL6AZL37JSu_4eS-ruy4FV8rmHcaAgfvzm1LY/edit?usp=sharing

Screenshots are at: https://drive.google.com/drive/folders/1sZVYNTqyTUzioo9m6nbzgjhpAUQhUqgR?usp=sharing

@robodoo
Copy link
Collaborator

robodoo commented Apr 17, 2025

Pull request status dashboard

@sclo-odoo sclo-odoo marked this pull request as ready for review April 17, 2025 12:45
@sclo-odoo
Copy link
Contributor Author

@vbe-odoo Here's the PR of NFC-e

@sclo-odoo
Copy link
Contributor Author

sclo-odoo commented Apr 22, 2025

@samueljlieber Hello!
Here's the PR for NFC-e E-invoice flow. Ready for review

I'm running the guideline tests on this last build, but it still saying that there's an error on a file called Tyro.srt that I don't know about.

But my doc seems Ok to me. Let me know if I need to do any adjustments

cc @vbe-odoo

@samueljlieber samueljlieber force-pushed the sclo-odoo-l10n-br-nfc-e-feature branch from e6b2d53 to 064807c Compare April 23, 2025 13:44
@samueljlieber samueljlieber changed the base branch from 18.0 to master April 23, 2025 13:45
@samueljlieber samueljlieber changed the base branch from master to 18.0 April 23, 2025 13:45
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sclo-odoo! Thank you for your work on this PR!

I hope you don't mind, since there were a number of changes, I've made a commit (064807c) to address the following:

  • Modified RST syntax to match conventions and guidelines
  • Added additional context for instruction where it was needed
  • Only added images that were necessary/helpful

With these changes, this PR should be all set to move to final review. However, @sclo-odoo please let me know your thoughts on my changes and I can make any final adjustments before sending to final review! Thank you! :)

@sclo-odoo
Copy link
Contributor Author

@samueljlieber Hello!
I saw the adjustments, that's ok to me! It's already good!

You can go forward with it.

@samueljlieber samueljlieber force-pushed the sclo-odoo-l10n-br-nfc-e-feature branch from 064807c to a510db2 Compare April 23, 2025 16:57
@samueljlieber
Copy link
Contributor

Squashed commits in a510db2

@C3POdoo C3POdoo requested a review from a team April 23, 2025 16:59
@afma-odoo
Copy link
Contributor

Hi @sclo-odoo @samueljlieber!

Thanks for the update on the Brazilian page!
We're currently testing a new template and guidelines for localization documentation pages.
Since this update on the Brazilian page is quite big, it might be a good opportunity to apply those principles and make some structural adjustments to the page.
If you'd like to update this, I can provide you with the new template and guidelines.
Alternatively, I'd be happy to make the changes myself. But please note that I'll be off starting next Tuesday through Friday.

Let me know what you prefer. Thank you ☺️

@samueljlieber
Copy link
Contributor

Hey @afma-odoo! Im excited to see the updated guidelines!

Im okay with you updaing this PR, but Im going to leave it up to @sclo-odoo to make the decision :)

@vbe-odoo
Copy link
Contributor

vbe-odoo commented Apr 25, 2025

Hello @afma-odoo, thanks for the heads up!
Please, help us with the adaptations for this PR, and if you have the new "template and guidelines for localization documentation pages" please share them with us for future reference.

Moreover, we will use what you do here to have a real example besides the new guidelines.

Thanks!
cc' @sclo-odoo

@sclo-odoo
Copy link
Contributor Author

Thank you @afma-odoo @vbe-odoo @samueljlieber
I think AFMA can apply the final changes and we're gonna see and learn about the new guidelines for the next ones.
💯

@afma-odoo
Copy link
Contributor

Hi @samueljlieber @vbe-odoo @sclo-odoo!
Thanks for your replies ;) Sure, I'll apply the changes!

Here is the guideline/template that you can use for future updates.
Feel free to reach out if you have any questions!

@sclo-odoo
Copy link
Contributor Author

Thank you so much @afma-odoo !

Waiting for the changes get applied 💯

Let me know if we need to do anything more.

@afma-odoo afma-odoo force-pushed the sclo-odoo-l10n-br-nfc-e-feature branch from a510db2 to 2e283ad Compare May 8, 2025 14:14
Adding the NFC-e configurations and workflows to the user guide.
@afma-odoo afma-odoo force-pushed the sclo-odoo-l10n-br-nfc-e-feature branch from 2e283ad to 3d27f89 Compare May 8, 2025 14:29
@afma-odoo
Copy link
Contributor

Hi @samueljlieber @vbe-odoo @sclo-odoo!
I've just force-pushed the changes related to the new guidelines/templates for loc doc pages, as well as some related to our documentation guidelines.
Could you please take a look and let me know if I missed anything? Thanks! 🙂

For your info, the "Localization overview" section includes all general info or content that applies to more than one app.

Regarding images, we generally tend to use them sparingly and only when necessary to avoid the need for frequent updates with new versions. Additionally, wide images can be hard to read on lower-resolution screens. We also don't use markups like rectangles or arrows on screenshots. Could you check and remove anything unnecessary or update the images that need adjustments? Thank you!

Please don’t hesitate to reach out if you have any questions. 🙂

Thanks for your patience; I truly appreciate it!

@sclo-odoo
Copy link
Contributor Author

@afma-odoo Hello!

About the content, it seems very good and direct, to me! About the images, unfortunately those 2 ones are not being rendered, I don't know why haha
image

This is already good to me, thank you so much for all changes.

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great to me @afma-odoo, thank you for your work!

Could you check and remove anything unnecessary or update the images that need adjustments?

Would it be acceptable to address removing/updating the existing images in another PR? The images added in this PR do not include any markup, and seem to be helpful to contextualize the NFC-e feature.

I suggest that we merge this PR as is, and open another IMP to address the existing l10n_br doc images? WDYT?

Thank you again :)

@afma-odoo afma-odoo requested a review from a team May 13, 2025 07:26
@afma-odoo
Copy link
Contributor

afma-odoo commented May 13, 2025

@sclo-odoo @samueljlieber Great! I’m glad it works well for you ☺️

Would it be acceptable to address removing/updating the existing images in another PR? The images added in this PR do not include any markup, and seem to be helpful to contextualize the NFC-e feature.

I suggest that we merge this PR as is, and open another IMP to address the existing l10n_br doc images? WDYT?

Sure, let's do that! I approved it and added the be-doc-review for the next step ;)

Thank you for updating the page ;)

Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you guys for the tremendous work on this!

@robodoo r+

@robodoo robodoo closed this in dcd5eea May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants