-
Notifications
You must be signed in to change notification settings - Fork 10.2k
[IMP] Attendances: updating configurations #12979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @Felicious - this is ready for a peer-review! Just be sure to read my PR comment - I did not thoroughly do the second half of the doc, because I realized (after starting this one!) that they can be moved to their own stand-alone docs, with more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see you getting back into documentation writing, @larm-odoo! 😊
I reviewed everything up to the Overview section. The only required change I flagged was the menuselection usage—everything else is just optional suggestions to help tighten the structure and flow of your explanations. It's already looking solid so far—excited to see the rest come together!
Since there was a delay on my part getting to reviewing your PR, let's fast track this to Sam's tech review after your edits!
03d848e
to
eb9bdef
Compare
Hi @samueljlieber - per FEKU, I am tagging you for a tech review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @larm-odoo, nice job with these updates! Im approving now with a request to update any remaining emojis in this doc with icons. Thank you!
..
@robodoo delegate=larm-odoo
eb9bdef
to
8281f3d
Compare
Thank you @samueljlieber! I missed those since those icons were in the section I was going to migrate to a new doc (after this is published). I'm glad you mentioned it, in case I miss it in the migration! |
@robodoo r+ |
This section is to update only the top half, with all the configuration infomration.
Another PR will MOVE the "Overview" and "Reporting" sections to new, stand-alone docs, so the information in those sections was not thoroughly re-written (since they will be redone in the following 2 PR's for each of those sections/docs)
This PR is for ONLY the parts above those sections, covering the intro and configurations menu.