-
Notifications
You must be signed in to change notification settings - Fork 9.9k
[IMP] accounting: reports groupby non-stored fields #13126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e9ed34d
to
b5e1681
Compare
e4502a1
to
2e4b476
Compare
Hi @Megaaaaaa , thanks for your patience on this one as we have a bit of a backlog for accounting/localization documentation reviews. Rather than send a bunch of comments nitpicking on changes, I've made the changes myself, focusing on RST format, avoiding second person (when reasonable), and explaining concepts in written text instead of relying on screenshots, all in an effort to better fit our content guidelines. I've also made changes to other parts of this documentation besides the section that you added. |
2e4b476
to
5e03bd4
Compare
Looks good to me. @tsb-odoo, do you want to have one last look ? |
Hey @tsb-odoo , do you want to take one last look to check the accuracy of what we have here or should we go ahead with a final review from the doc team and publish? |
@dade-odoo I think we should merge this as is, all looks good tbh, if something's really problematic, we can always iterate 👍 |
I agree |
In 18.0, [this commit](odoo/enterprise@3fcf1ae) added the ability to group by fields that are non stored. This commit adds documentation about how to use the feature. task-4698321
5e03bd4
to
3851b6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Megaaaaaa I force-pushed some minor changes (rebased to be able to reference a new doc; added a few refs, etc, fixed some formatting issues, etc.).
Thank you for your work and thank you @dade-odoo for the thorough review!
@robodoo r+
In 18.0, this commit added the ability to group by fields that are non stored. This commit adds documentation about how to use the feature.
task-4698321