Skip to content

[IMP] accounting: reports groupby non-stored fields #13126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Megaaaaaa
Copy link
Contributor

In 18.0, this commit added the ability to group by fields that are non stored. This commit adds documentation about how to use the feature.


task-4698321

@robodoo
Copy link
Collaborator

robodoo commented Apr 28, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team April 28, 2025 14:31
@Megaaaaaa Megaaaaaa force-pushed the 18.0-doc_reports_groupby_related_non_stored-thbe branch 2 times, most recently from e9ed34d to b5e1681 Compare April 29, 2025 06:35
@dade-odoo dade-odoo self-assigned this May 8, 2025
@dade-odoo dade-odoo removed the request for review from a team May 8, 2025 06:36
@dade-odoo dade-odoo force-pushed the 18.0-doc_reports_groupby_related_non_stored-thbe branch 2 times, most recently from e4502a1 to 2e4b476 Compare May 16, 2025 11:28
@dade-odoo
Copy link
Contributor

Hi @Megaaaaaa , thanks for your patience on this one as we have a bit of a backlog for accounting/localization documentation reviews. Rather than send a bunch of comments nitpicking on changes, I've made the changes myself, focusing on RST format, avoiding second person (when reasonable), and explaining concepts in written text instead of relying on screenshots, all in an effort to better fit our content guidelines. I've also made changes to other parts of this documentation besides the section that you added.
Will you please review my changes to make sure I haven't altered the meaning of any of the explanations and left out anything that was technically necessary? Thanks!

@dade-odoo dade-odoo force-pushed the 18.0-doc_reports_groupby_related_non_stored-thbe branch from 2e4b476 to 5e03bd4 Compare May 21, 2025 13:44
@dade-odoo dade-odoo requested a review from tsb-odoo May 22, 2025 13:56
@Megaaaaaa
Copy link
Contributor Author

Looks good to me. @tsb-odoo, do you want to have one last look ?

@dade-odoo
Copy link
Contributor

Hey @tsb-odoo , do you want to take one last look to check the accuracy of what we have here or should we go ahead with a final review from the doc team and publish?

@Megaaaaaa
Copy link
Contributor Author

@dade-odoo I think we should merge this as is, all looks good tbh, if something's really problematic, we can always iterate 👍

@tsb-odoo
Copy link

I agree

@dade-odoo dade-odoo requested review from a team and removed request for tsb-odoo July 14, 2025 11:34
@xpl-odoo xpl-odoo requested review from auva-odoo and removed request for a team July 15, 2025 11:17
In 18.0, [this commit](odoo/enterprise@3fcf1ae) added the ability to group by fields that are
non stored. This commit adds documentation about how to use the feature.

task-4698321
@auva-odoo auva-odoo force-pushed the 18.0-doc_reports_groupby_related_non_stored-thbe branch from 5e03bd4 to 3851b6a Compare July 15, 2025 12:35
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Megaaaaaa I force-pushed some minor changes (rebased to be able to reference a new doc; added a few refs, etc, fixed some formatting issues, etc.).

Thank you for your work and thank you @dade-odoo for the thorough review!

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants