[ADD] barcode: operations and commands barcode printing #13355

slinkous · 2025-05-13T00:54:07Z

No description provided.

robodoo · 2025-05-13T00:54:10Z

Felicious

Great work so far, @slinkous ! 😊 The doc is really in-depth and it's going to be SO helpful! 😍

I know you haven't requested a review from me, yet! I just did a quick scan 👀 😉 to catch some quick formatting and style things. I presumed that since you pushed this PR up at the end of the day, you'll still have it open when you come in tomorrow, so it'll be easy to do some fixes before you move onto another task 😊

content/applications/inventory_and_mrp/barcode/setup/operation_types.rst

Felicious

super minor nitpicks! planning to send this to tech review next so i'd like to take a look before then (:

but wonderful job!!! really helpful & comprehensive doc

content/applications/inventory_and_mrp/barcode/setup/operation_types.rst

Felicious

Great doc with so much detail!! @slinkous Proud of your work 😊

I just really minor things to add, and you're getting more and more familiar with our style and conventions 😊

Starting from the next doc you push up, you'll be officially joining the other writers in our normal peer review process! Tag Jess or Lara in peer review, me in final, and then Sam in technical!

content/applications/inventory_and_mrp/barcode/setup/operation_types.rst

slinkous

@samueljlieber this is ready for review, and much appreciated!

samueljlieber

Hi @slinkous! Before I review would you mind resolving the merge conflict? Thank you!

slinkous · 2025-05-22T17:50:06Z

@samueljlieber conflict resolved. I swear that other change hadn't gone through until after I tagged you. 😅 Thanks for video guide!

samueljlieber · 2025-05-22T17:52:54Z

No worries @slinkous, thank you for taking care of it! Review coming soon!

samueljlieber

Hi @slinkous! Awesome work on this Barcode PR! The doc is really in-depth and I like the amount of reference links you used to add more additional context.

Im requesting changes just to address and discuss a couple items, all pretty minor :)

Nitpicks- please correct the lines over 100 chars and early line breaks (can use make review to find these).

Tag me for one more quick look once you've had a moment to address these!

Thank you!

samueljlieber · 2025-05-22T18:35:16Z

...ent/applications/inventory_and_mrp/barcode/setup/operation_types/print-picking-inventory.png

Please remove this unused image :)
(content/applications/inventory_and_mrp/barcode/setup/operation_types/print-picking-inventory.png)

content/applications/inventory_and_mrp/barcode/setup/operation_types.rst

samueljlieber · 2025-05-22T19:58:22Z

content/applications/inventory_and_mrp/barcode/setup/operation_types.rst

+barcode if there is one available, or tap the :icon:`fa-cog` :guilabel:`(cog)` icon to open the
+Barcode Actions menu and tap the :guilabel:`Print Picking Operation` button.


Please use the "gear" label for this icon over "cog" :)

Bold Barcode app name and lowercase actions menu

Suggested change

barcode if there is one available, or tap the :icon:`fa-cog` :guilabel:`(cog)` icon to open the

Barcode Actions menu and tap the :guilabel:`Print Picking Operation` button.

barcode if there is one available, or tap the :icon:`fa-cog` :guilabel:`(gear)` icon to open the

**Barcode** actions menu and tap the :guilabel:`Print Picking Operation` button.

But otherwise the rule of explicit label > hover label > fontAwesome name applies? This one's just an old convention?

Yes, please see our Vale linter rule here: https://github.com/Felicious/odoo-vale-linter/blob/7b0e3b245ba4e4a8fb09d2c7345320979e3ef235/styles/Odoo/Icons.yml#L61

samueljlieber · 2025-05-22T19:59:27Z

content/applications/inventory_and_mrp/barcode/setup/operation_types.rst

+Operations
+----------
+
+- :guilabel:`Receipts (WHIN)` creates a new order to receive products into inventory.


Continuing from my prev comment, these are printed so no :guilabel: IMO, and could use literal for the codes (optional)

Suggested change

- :guilabel:`Receipts (WHIN)` creates a new order to receive products into inventory.

- **Receipts** (`WHIN`) creates a new order to receive products into inventory.

Okay, I like this solution! I ran through italics/bold/literal for the whole phrase, but the parentheses are my addition as well. I'm going to convert it all to **Operation Name** \BARCODE``, because it looks the most like the actual printed barcodes, and the barcodes themselves seem to all stick to monospace fonts.

I can't escape the backticks. I think you'll get what I mean though.

Yes! I agree :)

**Operation Name** `BARCODE`

content/applications/inventory_and_mrp/barcode/setup/operation_types.rst

slinkous · 2025-05-23T19:24:33Z

@samueljlieber This is ready for re-review. Tysm for formatting help!

samueljlieber

Hi @slinkous, thank you for addressing most of my comments– however there are still a few left to resolve.

Please remove this unused image: #13355 (comment)

Please tag me once more once addressed. Thank you!

content/applications/inventory_and_mrp/barcode/setup/operation_types.rst

samueljlieber

Thank you for addressing everything @slinkous, looks good. Approving with one comment!

Thank you for your work!
.....
@robodoo delegate=slinkous

content/applications/inventory_and_mrp/barcode/setup/operation_types.rst

slinkous · 2025-05-23T22:14:04Z

@robodoo r+

robodoo · 2025-05-23T22:14:06Z

@slinkous you may want to rebuild or fix this PR as it has failed CI.

Co-authored-by: Felicious <feku@odoo.com>

slinkous · 2025-05-23T23:03:30Z

@robodoo r+

C3POdoo requested a review from a team May 13, 2025 00:55

Felicious reviewed May 13, 2025

View reviewed changes

Felicious requested changes May 16, 2025

View reviewed changes

slinkous force-pushed the 18.0-barcode-operation-barcodes-stul branch from c39a65e to d93f642 Compare May 21, 2025 00:17

slinkous requested a review from Felicious May 21, 2025 00:18

Felicious approved these changes May 21, 2025

View reviewed changes

slinkous force-pushed the 18.0-barcode-operation-barcodes-stul branch from 67e5404 to 93694be Compare May 21, 2025 18:44

slinkous self-assigned this May 21, 2025

slinkous added the 5 label May 21, 2025

slinkous requested review from Felicious and samueljlieber May 21, 2025 19:48

slinkous commented May 21, 2025

View reviewed changes

samueljlieber reviewed May 21, 2025

View reviewed changes

slinkous force-pushed the 18.0-barcode-operation-barcodes-stul branch from 4aef40b to 26fb546 Compare May 22, 2025 17:17

samueljlieber requested changes May 22, 2025

View reviewed changes

slinkous force-pushed the 18.0-barcode-operation-barcodes-stul branch from 26fb546 to fcf2f00 Compare May 23, 2025 18:51

slinkous requested a review from samueljlieber May 23, 2025 18:52

samueljlieber requested changes May 23, 2025

View reviewed changes

content/applications/inventory_and_mrp/barcode/setup/operation_types.rst Outdated Show resolved Hide resolved

content/applications/inventory_and_mrp/barcode/setup/operation_types.rst Outdated Show resolved Hide resolved

slinkous force-pushed the 18.0-barcode-operation-barcodes-stul branch from fcf2f00 to 92641da Compare May 23, 2025 20:09

samueljlieber approved these changes May 23, 2025

View reviewed changes

content/applications/inventory_and_mrp/barcode/setup/operation_types.rst Outdated Show resolved Hide resolved

slinkous force-pushed the 18.0-barcode-operation-barcodes-stul branch 3 times, most recently from 282efa0 to f5ed712 Compare May 23, 2025 21:50

[ADD] barcode: operations and commands barcode printing

bbd7f5a

Co-authored-by: Felicious <feku@odoo.com>

slinkous force-pushed the 18.0-barcode-operation-barcodes-stul branch from f5ed712 to bbd7f5a Compare May 23, 2025 22:21

robodoo closed this in 8ff28d6 May 24, 2025

robodoo temporarily deployed to merge May 24, 2025 02:00 Inactive

		barcode if there is one available, or tap the :icon:`fa-cog` :guilabel:`(cog)` icon to open the
		Barcode Actions menu and tap the :guilabel:`Print Picking Operation` button.

	- :guilabel:`Receipts (WHIN)` creates a new order to receive products into inventory.
	- Receipts (`WHIN`) creates a new order to receive products into inventory.

[ADD] barcode: operations and commands barcode printing #13355

[ADD] barcode: operations and commands barcode printing #13355

Uh oh!

Conversation

slinkous commented May 13, 2025

Uh oh!

robodoo commented May 13, 2025

Uh oh!

Felicious left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Felicious left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Felicious left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

slinkous left a comment

Choose a reason for hiding this comment

Uh oh!

samueljlieber left a comment

Choose a reason for hiding this comment

Uh oh!

slinkous commented May 22, 2025

Uh oh!

samueljlieber commented May 22, 2025

Uh oh!

samueljlieber left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

slinkous May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

slinkous commented May 23, 2025

Uh oh!

samueljlieber left a comment

slinkous May 22, 2025 •

edited

Loading