Skip to content

[IMP] Time Off: Updating Management #14185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

larm-odoo
Copy link
Contributor

Updating to new standards with new images.

Original task card for this PR.

@robodoo
Copy link
Collaborator

robodoo commented Jul 28, 2025

Pull request status dashboard

@larm-odoo larm-odoo self-assigned this Jul 28, 2025
@larm-odoo larm-odoo added the 2 label Jul 28, 2025
@larm-odoo larm-odoo requested review from jero-odoo and a team and removed request for jero-odoo July 28, 2025 21:24
@larm-odoo
Copy link
Contributor Author

Hi @jero-odoo - this is ready for a review!

@C3POdoo C3POdoo requested a review from a team July 28, 2025 21:25
Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @larm-odoo ! Just a few suggestions

@@ -39,8 +38,8 @@ The various departments the user is a member of, and manages employees under, al
left side of the page, under :guilabel:`Departments`.

.. note::
If there are no requests that fall under one of the status options or departments, that status
or department is **not** visible on the left-side menu.
If there are no requests that fall under one of the status options or departments, that status or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If there are no requests that fall under one of the status options or departments, that status or
If no requests fall under one of the status options or departments, that status or

Comment on lines +93 to +94
and :guilabel:`My Team`. These default filters *only* present employees on the user's team (who they
manage) that are awaiting the first approval. Approved and refused allocation requests are not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
and :guilabel:`My Team`. These default filters *only* present employees on the user's team (who they
manage) that are awaiting the first approval. Approved and refused allocation requests are not
and :guilabel:`My Team`. These default filters only present employees that the user manages and are awaiting their first approval. Approved and refused allocation requests are not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants