[IMP] tests: enable additional resource file-related checkers #14650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Feyensv
approved these changes
Sep 23, 2025
AntoineVDV
force-pushed
the
17.0-enable-additionnal-checkers-anv
branch
from
d64a62b to
6f95275
Compare
The following custom checkers were never run by the `ci/documentation_guidelines` build and had to be run locally with `make review`: - `check_image_size`: Check that images are not larger than the maximum file size allowed for their extension. - `check_image_color_depth`: Check that PNG images are compressed to 8-bit color depth with PNGQuant. - `check_resource_file_name`: Check that resource file names use hyphens rather than underscores. Since reviewers systematically perform these checks manually, it makes sense to include them in the standard test suite. Should a check raise a false positive (e.g., an `example_db.zip` resource file is added and hyphens should not be used), the red CI can be safely ignored as it is not required for merging.
AntoineVDV
force-pushed
the
17.0-enable-additionnal-checkers-anv
branch
from
6f95275 to
4ca59ad
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Sep 29, 2025
The following custom checkers were never run by the `ci/documentation_guidelines` build and had to be run locally with `make review`: - `check_image_size`: Check that images are not larger than the maximum file size allowed for their extension. - `check_image_color_depth`: Check that PNG images are compressed to 8-bit color depth with PNGQuant. - `check_resource_file_name`: Check that resource file names use hyphens rather than underscores. Since reviewers systematically perform these checks manually, it makes sense to include them in the standard test suite. Should a check raise a false positive (e.g., an `example_db.zip` resource file is added and hyphens should not be used), the red CI can be safely ignored as it is not required for merging. closes #14650 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following custom checkers were never run by the
ci/documentation_guidelinesbuild and had to be run locally withmake review:check_image_size: Check that images are not larger than the maximum file size allowed for their extension.check_image_color_depth: Check that PNG images are compressed to 8-bit color depth with PNGQuant.check_resource_file_name: Check that resource file names use hyphens rather than underscores.Since reviewers systematically perform these checks manually, it makes sense to include them in the standard test suite. Should a check raise a false positive (e.g., an
example_db.zipresource file is added and hyphens should not be used), the red CI can be safely ignored as it is not required for merging.