Skip to content

Conversation

kmagusiak
Copy link
Contributor

@kmagusiak kmagusiak requested a review from d-fence October 3, 2025 07:06
@robodoo
Copy link
Collaborator

robodoo commented Oct 3, 2025

Pull request status dashboard

Copy link
Member

@Julien00859 Julien00859 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sudo -u @odoo/documents-doc-review @robodoo r+ plz

@KangOl KangOl force-pushed the master-bump-py312-krma branch from be6c9dc to fc4a561 Compare October 8, 2025 14:44
@KangOl
Copy link
Contributor

KangOl commented Oct 9, 2025

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Oct 9, 2025

I'm sorry, @KangOl. I'm afraid I can't do that.

@kmagusiak
Copy link
Contributor Author

@odoo/doc-review can you r+?

@KangOl KangOl requested a review from Julien00859 October 9, 2025 11:56
@Feyensv
Copy link
Collaborator

Feyensv commented Oct 9, 2025

@/odoo/doc-review can you r+?

Please assign us as reviewers when a doc PR is ready ;)

Comment on lines +200 to +205
.. versionchanged:: 19
Minimum requirement updated from PostgreSQL 12 to PostgreSQL 13.

.. versionchanged:: 20
Minimum requirement updated from PostgreSQL 13 to PostgreSQL 16.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do this since the doc is versioned.
The displayed requirements should match the version whose documentation you're reading, that's all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just copied from the existing one in the Python section (line 123)

Copy link
Collaborator

@Feyensv Feyensv Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we weren't notified of #5940 introducing it so we didn't block it :D

@AntoineVDV
Copy link
Collaborator

@Julien00859 @odoo/documents-doc-review is the team responsible for the Documents app 😛

Copy link
Collaborator

@Feyensv Feyensv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+ delegate+

robodoo pushed a commit to odoo/odoo that referenced this pull request Oct 9, 2025
Once Odoo 20.0 will be out, older postgresql versions will be (soon) out of
support. We set the minimal supported version to the version already available
today in the current Ubunut LTS version (24.04).

Non-exhaustive list of new features that we can now use:
- MERGE: https://www.postgresql.org/docs/16/sql-merge.html
- UNIQUE NULLS NOT DISTINCT:
  https://www.postgresql.org/docs/16/indexes-unique.html

Part-of: #229675
Related: odoo/documentation#14771
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
robodoo pushed a commit to odoo/odoo that referenced this pull request Oct 9, 2025
Select the minimum python version for Odoo 20.0 release.
We are looking at Debian 13 and Ubuntu 24.04 and 26.04 (which will be
released before Odoo 20.0). The minimum version of these systems is
python 3.12.

closes #229675

Related: odoo/documentation#14771
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
robodoo pushed a commit that referenced this pull request Oct 9, 2025
See odoo/odoo#229675

closes #14771

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
robodoo pushed a commit to odoo/odoo that referenced this pull request Oct 9, 2025
Once Odoo 20.0 will be out, older postgresql versions will be (soon) out of
support. We set the minimal supported version to the version already available
today in the current Ubunut LTS version (24.04).

Non-exhaustive list of new features that we can now use:
- MERGE: https://www.postgresql.org/docs/16/sql-merge.html
- UNIQUE NULLS NOT DISTINCT:
  https://www.postgresql.org/docs/16/indexes-unique.html

Part-of: #229675
Related: odoo/documentation#14771
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
robodoo pushed a commit to odoo/odoo that referenced this pull request Oct 9, 2025
Select the minimum python version for Odoo 20.0 release.
We are looking at Debian 13 and Ubuntu 24.04 and 26.04 (which will be
released before Odoo 20.0). The minimum version of these systems is
python 3.12.

closes #229675

Related: odoo/documentation#14771
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
robodoo pushed a commit that referenced this pull request Oct 9, 2025
See odoo/odoo#229675

closes #14771

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
@robodoo robodoo added the 19.1 label Oct 9, 2025
@robodoo robodoo closed this Oct 9, 2025
@kmagusiak kmagusiak deleted the master-bump-py312-krma branch October 9, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants