[IMP] Sales - Update optional_products.rst #4404

ksc-odoo · 2023-05-10T20:54:21Z

adhered new formatting rules to old doc (v14) related to Optional Products (under Sales > Send Quotations) @samueljlieber

Project Task: 3329153

robodoo · 2023-05-10T20:54:38Z

Pull request status dashboard.

ksc-odoo

👍

samueljlieber

Hi @ksc-odoo I have a handful of technical changes to this PR, please see them below. Let me know if you have any questions or want help with any of the edits! Thank you :)

samueljlieber · 2023-05-15T13:42:09Z

content/applications/sales/sales/send_quotations/optional_products.rst

+along with a core product. The aim is to offer useful and related products to customers, which may result
+in an increased sale.


Late 100th char line break

samueljlieber · 2023-05-15T13:48:49Z

content/applications/sales/sales/send_quotations/optional_products.rst

-(under the **Optional Products** tab, as you can see below).
+With the Odoo *Sales* application, it is possible to add or modify optional products directly on
+quotations (located under the :guilabel:`Optional Products` tab on a quotation form, in the *Sales*
+application).

 .. image:: optional_products/optional_products_2.png


Note on images - since we are already improving this document, please update the images to follow our guidelines being sure to retaking screenshots if they cannot be resized and still be legible as well as have the correct filename convention (maximum width of 933px or ideally 768px wide & descriptive hyphenated filename). Please let me know if you have any questions! 🙂

samueljlieber · 2023-05-15T13:49:18Z

content/applications/sales/sales/send_quotations/optional_products.rst


 .. image:: optional_products/optional_products_2.png
   :align: center
-   :class: img-thumbnail
   :alt: How to add optional products to your quotations on Odoo Sales


Let's add periods to alt tags

samueljlieber · 2023-05-15T13:50:05Z

content/applications/sales/sales/send_quotations/optional_products.rst

-using associated carts, with a user-friendly layout. More than that, if a customer selects all the
-optional products suggested, these additional items will automatically fill in the quotation
-managed by the salesman.
+In practice, your customers are able to add different optional products to an order by clicking the


Suggested change

In practice, your customers are able to add different optional products to an order by clicking the

In practice, customers are able to add different optional products to an order by clicking the

samueljlieber · 2023-05-15T13:51:49Z

content/applications/sales/sales/send_quotations/optional_products.rst


-Be sure to check out our documentation about :doc:`quote_template` to understand how you can
-enable, create, design and manage your own quotation templates before reading this part.
+Be sure to review the documentation about :doc:`quote_template` to better understand how quotation


Please use global relative paths rather than local relative paths

Suggested change

Be sure to review the documentation about :doc:`quote_template` to better understand how quotation

Be sure to review the documentation about

:doc:`/applications/sales/sales/send_quotations/quote_template` to better understand how quotation

content/applications/sales/sales/send_quotations/optional_products.rst

ksc-odoo · 2023-05-15T19:33:49Z

Hi @ksc-odoo I have a handful of technical changes to this PR, please see them below. Let me know if you have any questions or want help with any of the edits! Thank you :)

Hey @samueljlieber thanks for the awesome technical review. I made all the suggested changes (both RST and image-wise), which can be found here: https://drive.google.com/drive/folders/1OtwEbMmzukSVRjGCWMzt8YadC-OiQ6Vc?usp=sharing

If there's anything else you need from me, just let me know. thanks again! 👍

samueljlieber

Hi @ksc-odoo nice job with making the previous changes, I caught a couple more, please see below. Once these changes are made, tag me once more and this PR should be good to go for final review. Thank you! 🙂

content/applications/sales/sales/send_quotations/optional_products.rst

samueljlieber · 2023-05-18T13:39:47Z

content/applications/sales/sales/send_quotations/optional_products.rst

+products added under the :guilabel:`Optional Products` tab are present in the quotation, by
+default, whenever that particular quotation template is used.


early 100th char line break

I see. I only made this break because I thought that since the comma was right after the word "default" (in other words no spaces separating the two) that it needed to be knocked down to the next line. No worries, though. I slightly restructured the sentence to make everything work. Thanks 👍

samueljlieber · 2023-05-18T13:40:02Z

content/applications/sales/sales/send_quotations/optional_products.rst


 .. seealso::
-   - :doc:`quote_template`
+   :doc:`quote_template`


Please use global relative paths instead of local relative paths

ksc-odoo · 2023-05-18T17:21:59Z

Hi @ksc-odoo nice job with making the previous changes, I caught a couple more, please see below. Once these changes are made, tag me once more and this PR should be good to go for final review. Thank you! 🙂

Alrighty @samueljlieber - i made all the necessary changes - thanks again for your consistently AWESOME reviews/feedback/help/expertise! Let me know if there's anything else I need to adjust before it can move on to the Final Review stage - thanks again! 👍

samueljlieber

Hi @ksc-odoo great job with this PR - looks good to me! Moving to final review @StraubCreative 🙂

StraubCreative · 2023-06-15T14:18:20Z

Fresh rebase on f37cd95.

StraubCreative

Hello @ksc-odoo 👋
Couple change requests below, thanks!

content/applications/sales/sales/send_quotations/optional_products.rst

ksc-odoo · 2023-06-15T18:22:11Z

Hello @ksc-odoo 👋 Couple change requests below, thanks!

Thanks for the awesome suggestions! Ready for another quick look, whenever you get a chance 👍 @StraubCreative

StraubCreative

Hi @ksc-odoo
approving with 2 comments
merge when ready 👍

@robodoo delegate=ksc-odoo

content/applications/sales/sales/send_quotations/optional_products.rst

ksc-odoo · 2023-08-08T17:52:50Z

@robodoo r+

closes #4404 Signed-off-by: Kevin Scannell (ksc) <ksc@odoo.com>

fw-bot · 2023-08-12T05:53:34Z

@ksc-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

fw-bot · 2023-08-13T05:54:13Z

@ksc-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

fw-bot · 2023-08-14T05:56:15Z

@ksc-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

fw-bot · 2023-08-15T05:56:05Z

@ksc-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

fw-bot · 2023-08-16T05:56:08Z

@ksc-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

fw-bot · 2023-08-17T05:54:51Z

@ksc-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

fw-bot · 2023-08-18T05:54:38Z

@ksc-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

ksc-odoo requested a review from samueljlieber May 10, 2023 20:54

ksc-odoo self-assigned this May 10, 2023

C3POdoo requested a review from a team May 10, 2023 20:55

ksc-odoo commented May 10, 2023

View reviewed changes

samueljlieber requested changes May 15, 2023

View reviewed changes

ksc-odoo force-pushed the 14.0-sales-update-optional-products-ksc branch from 1fff1e9 to 5a25828 Compare May 17, 2023 22:09

ksc-odoo requested a review from samueljlieber May 17, 2023 22:09

samueljlieber requested changes May 18, 2023

View reviewed changes

ksc-odoo force-pushed the 14.0-sales-update-optional-products-ksc branch from 5a25828 to bd49689 Compare May 18, 2023 17:20

ksc-odoo requested a review from samueljlieber May 18, 2023 17:23

samueljlieber approved these changes May 19, 2023

View reviewed changes

samueljlieber requested a review from StraubCreative May 19, 2023 14:18

StraubCreative force-pushed the 14.0-sales-update-optional-products-ksc branch from bd49689 to f37cd95 Compare June 15, 2023 14:18

StraubCreative requested changes Jun 15, 2023

View reviewed changes

ksc-odoo force-pushed the 14.0-sales-update-optional-products-ksc branch 2 times, most recently from 89dbc81 to cde7787 Compare June 15, 2023 18:19

ksc-odoo requested a review from StraubCreative June 15, 2023 18:22

StraubCreative approved these changes Aug 8, 2023

View reviewed changes

content/applications/sales/sales/send_quotations/optional_products.rst Outdated Show resolved Hide resolved

content/applications/sales/sales/send_quotations/optional_products.rst Outdated Show resolved Hide resolved

[IMP] Sales - Update optional_products.rst

9e7d32f

ksc-odoo force-pushed the 14.0-sales-update-optional-products-ksc branch from cde7787 to 9e7d32f Compare August 8, 2023 17:50

robodoo pushed a commit that referenced this pull request Aug 8, 2023

[IMP] Sales - Update optional_products.rst

4d95afe

closes #4404 Signed-off-by: Kevin Scannell (ksc) <ksc@odoo.com>

robodoo temporarily deployed to merge August 8, 2023 19:09 Inactive

robodoo closed this Aug 8, 2023

fw-bot mentioned this pull request Aug 8, 2023

[FW][IMP] Sales - Update optional_products.rst #5408

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] Sales - Update optional_products.rst #4404

[IMP] Sales - Update optional_products.rst #4404

ksc-odoo commented May 10, 2023 •

edited by StraubCreative

Loading

robodoo commented May 10, 2023

ksc-odoo left a comment

samueljlieber left a comment

samueljlieber May 15, 2023

samueljlieber May 15, 2023

samueljlieber May 15, 2023

samueljlieber May 15, 2023

samueljlieber May 15, 2023

ksc-odoo commented May 15, 2023

samueljlieber left a comment

samueljlieber May 18, 2023

ksc-odoo May 18, 2023

samueljlieber May 18, 2023

ksc-odoo commented May 18, 2023

samueljlieber left a comment

StraubCreative commented Jun 15, 2023

StraubCreative left a comment

ksc-odoo commented Jun 15, 2023

StraubCreative left a comment

ksc-odoo commented Aug 8, 2023

fw-bot commented Aug 12, 2023

fw-bot commented Aug 13, 2023

fw-bot commented Aug 14, 2023

fw-bot commented Aug 15, 2023

fw-bot commented Aug 16, 2023

fw-bot commented Aug 17, 2023

fw-bot commented Aug 18, 2023

		along with a core product. The aim is to offer useful and related products to customers, which may result
		in an increased sale.

	In practice, your customers are able to add different optional products to an order by clicking the
	In practice, customers are able to add different optional products to an order by clicking the

	Be sure to review the documentation about :doc:`quote_template` to better understand how quotation
	Be sure to review the documentation about
	:doc:`/applications/sales/sales/send_quotations/quote_template` to better understand how quotation

		products added under the :guilabel:`Optional Products` tab are present in the quotation, by
		default, whenever that particular quotation template is used.

[IMP] Sales - Update optional_products.rst #4404

[IMP] Sales - Update optional_products.rst #4404

Conversation

ksc-odoo commented May 10, 2023 • edited by StraubCreative Loading

robodoo commented May 10, 2023

ksc-odoo left a comment

Choose a reason for hiding this comment

samueljlieber left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ksc-odoo commented May 15, 2023

samueljlieber left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ksc-odoo commented May 18, 2023

samueljlieber left a comment

Choose a reason for hiding this comment

StraubCreative commented Jun 15, 2023

StraubCreative left a comment

Choose a reason for hiding this comment

ksc-odoo commented Jun 15, 2023

StraubCreative left a comment

Choose a reason for hiding this comment

ksc-odoo commented Aug 8, 2023

fw-bot commented Aug 12, 2023

fw-bot commented Aug 13, 2023

fw-bot commented Aug 14, 2023

fw-bot commented Aug 15, 2023

fw-bot commented Aug 16, 2023

fw-bot commented Aug 17, 2023

fw-bot commented Aug 18, 2023

ksc-odoo commented May 10, 2023 •

edited by StraubCreative

Loading