Skip to content

[IMP] mrp: update variants doc #5236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] mrp: update variants doc #5236

wants to merge 1 commit into from

Conversation

brse-odoo
Copy link
Contributor

This PR is an [IMP] targeting the product_variants doc in Odoo's MRP documentation.

Performed complete rewrite to the document for 14.0 to be fwd-ported (targeted revisions for 15.0 and 16.0 to follow).

  • Completely rewrote the .rst file and added example flow instructions
  • Added additional screenshots
  • Rewrote and added to doc to make more robust and comprehensive than before

@brse-odoo brse-odoo self-assigned this Jul 31, 2023
@robodoo
Copy link
Collaborator

robodoo commented Jul 31, 2023

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team July 31, 2023 15:51
@brse-odoo
Copy link
Contributor Author

Hi @odoo/manufacturing-doc-review this PR is ready for a review. Thanks in advance!

Felicious
Felicious requested changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job as usual, @brse-odoo 😊
I just had very minor suggestions about rewording paragraphs to let the user know what the instructions are achieving before getting into the instruction itself. Other than that, amazing improvement on a complicated doc!

@brse-odoo brse-odoo force-pushed the 14.0-mrp-update-bom-variants-brse branch from 8f0dbcc to 49aeed7 Compare August 23, 2023 20:00
@brse-odoo
Copy link
Contributor Author

@odoo/crm-doc-review This PR has passed the first round of content review, and is now ready for the second when one of you has the chance. Thank you!

@brse-odoo brse-odoo requested a review from a team August 30, 2023 14:05
ksc-odoo
ksc-odoo reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brse-odoo Alrighty - just finished my Peer Review of this doc. Nicely done. Only a few minor comments to review. If you have any questions, don't hesitate to reach out! 👍

@brse-odoo brse-odoo force-pushed the 14.0-mrp-update-bom-variants-brse branch from 49aeed7 to bd5ae53 Compare September 13, 2023 14:55
@brse-odoo
Copy link
Contributor Author

Hi @odoo/us-doc-review, this PR has passed the first two rounds of content review and is ready for the final round when one of you has a chance. Thank you!

@brse-odoo brse-odoo requested a review from a team September 13, 2023 15:04
@brse-odoo
Copy link
Contributor Author

Hi @odoo/us-doc-review Just bumping up this PR, since it is ready for final review -- thank you!

@brse-odoo
Copy link
Contributor Author

@odoo/us-doc-review Bumping up this PR again -- it is ready for final review. Thank you!

@samueljlieber samueljlieber force-pushed the 14.0-mrp-update-bom-variants-brse branch from bd5ae53 to 433ab00 Compare December 21, 2023 17:25
@samueljlieber samueljlieber force-pushed the 14.0-mrp-update-bom-variants-brse branch from 433ab00 to 940d9e0 Compare December 21, 2023 17:27
samueljlieber
samueljlieber approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this PR @brse-odoo ! I made a small commit to update the doc path on line 17 to be relative, and give the link a contextual name rather than "this doc".

@StraubCreative this PR is good to go!

StraubCreative
StraubCreative approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

robodoo pushed a commit that referenced this pull request Dec 22, 2023
@brse-odoo @samueljlieber
[IMP] mrp: update variants doc
04822cc 
closes #5236

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
@robodoo robodoo closed this Dec 22, 2023
@fw-bot fw-bot mentioned this pull request Dec 22, 2023
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Dec 25, 2023

@brse-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

1 similar comment
@fw-bot
Copy link
Collaborator

fw-bot commented Dec 26, 2023

@brse-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

This was referenced Dec 26, 2023
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 26, 2023
Closed
Closed
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Dec 27, 2023

@brse-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felicious Felicious Felicious requested changes

@StraubCreative StraubCreative StraubCreative approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

+1 more reviewer

@ksc-odoo ksc-odoo ksc-odoo left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@brse-odoo brse-odoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@brse-odoo @robodoo @fw-bot @StraubCreative @Felicious @samueljlieber @ksc-odoo