Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] CRM: rewrite gamification #8908

Closed
wants to merge 1 commit into from

Conversation

jero-odoo
Copy link
Contributor

@jero-odoo jero-odoo commented Apr 22, 2024

Docs task: https://www.odoo.com/mail/view?model=project.task&res_id=3878226&access_token=9a8cabb2-d227-44ac-9fe0-8746d9193e87
Complete rewrite: https://www.odoo.com/documentation/17.0/applications/sales/crm/optimize/gamification.html

Updating images and content for V17
Update to content standards
Adding content for creating challenges and rewards

@jero-odoo jero-odoo self-assigned this Apr 22, 2024
@robodoo
Copy link
Collaborator

robodoo commented Apr 22, 2024

@jero-odoo jero-odoo force-pushed the 17.0-crm-gamification-rewrite-jero branch 3 times, most recently from c888edd to 16e6ced Compare April 23, 2024 19:50
@jero-odoo jero-odoo marked this pull request as ready for review April 23, 2024 20:10
@jero-odoo
Copy link
Contributor Author

Hi @hojo-odoo this is ready for review. Thanks!

@C3POdoo C3POdoo requested a review from a team April 23, 2024 20:11
Copy link
Contributor

@hojo-odoo hojo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jero-odoo,

Great job on this doc. I'm approving with a few small suggestions.

Thanks,
hojo

content/applications/sales/crm/optimize/gamification.rst Outdated Show resolved Hide resolved
content/applications/sales/crm/optimize/gamification.rst Outdated Show resolved Hide resolved
content/applications/sales/crm/optimize/gamification.rst Outdated Show resolved Hide resolved
content/applications/sales/crm/optimize/gamification.rst Outdated Show resolved Hide resolved
content/applications/sales/crm/optimize/gamification.rst Outdated Show resolved Hide resolved
@jero-odoo jero-odoo force-pushed the 17.0-crm-gamification-rewrite-jero branch from fbecc1b to bdd520a Compare April 24, 2024 14:35
@jero-odoo
Copy link
Contributor Author

@StraubCreative this is ready for final. Thanks!

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo
Thanks for the rewrite!
Approving with comments, which I'll push up most of the revisions for in another commit. For the remaining comments (config + screenshot retake), let's address on a new PR.

content/applications/sales/crm/optimize/gamification.rst Outdated Show resolved Hide resolved
content/applications/sales/crm/optimize/gamification.rst Outdated Show resolved Hide resolved

Configuration
=============

Install the *Gamification* module, or the *CRM gamification* one, which adds some useful data
(goals and challenges) that can be used on *CRM/Sale*.
To install the *Gamification* module, navigate to the :menuselection:`Apps` application. Click into
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a follow-up PR let's re-examine this section. It's not exactly clear how or when these apps are installed automatically so let's try to cover that.

content/applications/sales/crm/optimize/gamification.rst Outdated Show resolved Hide resolved
content/applications/sales/crm/optimize/gamification.rst Outdated Show resolved Hide resolved
- :guilabel:`is in`
- `Sales/User: Own Documents Only`

.. image:: gamification/assignation-rule.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way the condition is showing in the field is a display bug (it should be flush with the row), so let's retake and zoom out slightly or increase browser window size.

@StraubCreative StraubCreative force-pushed the 17.0-crm-gamification-rewrite-jero branch from 63561ad to 0dad5d6 Compare April 26, 2024 22:27
Co-authored-by: hojo-odoo <123424465+hojo-odoo@users.noreply.github.com>
Co-authored-by: StraubCreative <zst@odoo.com>
@StraubCreative StraubCreative force-pushed the 17.0-crm-gamification-rewrite-jero branch from 0dad5d6 to 686e08c Compare April 26, 2024 22:30
@StraubCreative
Copy link
Contributor

@robodoo r+

@fw-bot
Copy link
Collaborator

fw-bot commented Apr 30, 2024

@fw-bot
Copy link
Collaborator

fw-bot commented May 1, 2024

@jero-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

1 similar comment
@fw-bot
Copy link
Collaborator

fw-bot commented May 2, 2024

@jero-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants