[FIX] adapt requirements to ubuntu Jammy #9115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavier-Do
force-pushed
the
master-update-requirements-xdo
branch
from
19ab791 to
0ec81ca
Compare
Xavier-Do
changed the title
Xavier-Do
force-pushed
the
master-update-requirements-xdo
branch
3 times, most recently
from
67777a3 to
6c714d1
Compare
The docutils is pinned to 0.16.0 while the Jammy version should be 0.17 This is the case for a compatibility issue with sphinx-tabs==3.2.0 also official versions in ubuntu Jammy. The odoo.requirements package contains already a docutils 0.17.0 creating some downgrade when installing requirements, this commit upgrade both dependency to a compatible version. This should avoid installing requirements in all documentation build and hopefully avoid some random errors.
Xavier-Do
force-pushed
the
master-update-requirements-xdo
branch
from
6c714d1 to
584be77
Compare
|
robodoo r+ |
|
duplicate of #6205 👀 |
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docutils is pinned to 0.16.0 while the Jammy version should be 0.17
This is the case for a compatibility issue with sphinx-tabs==3.2.0 also official versions in ubuntu Jammy.
The odoo.requirements package contains already a docutils 0.17.0 creating some downgrade when installing requirements, this commit upgrade both dependency to a compatible version.
The proposed solution pins sphinx-tabs to a higher version, compatible with docutils 0.17. Some investigation should still be done to check why the package versions in ubuntu focal are not compatible when installed via pip.
This should avoid installing requirements in all documentation build and hopefully avoid some random errors.
This will also avoid an random error where documentation requirements are installed before odoo ones
https://runbot.odoo.com/runbot/batch/1443963/build/62071320