Skip to content

[IMP] payment_xendit: tokenization #9394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nni-odoo
Copy link
Contributor

Tokenization is introduced in odoo/odoo#158445 and needs extra configuration to setup for credit card payment. We require optional 3DS to be enabled and dynamic 3DS to be disabled

@robodoo
Copy link
Collaborator

robodoo commented May 17, 2024

@nni-odoo nni-odoo self-assigned this May 17, 2024
@C3POdoo C3POdoo requested a review from a team May 17, 2024 02:21
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nni-odoo I suggested a small change to reflect the actual name of the page 🙂

@AntoineVDV
Copy link
Collaborator

Hello @nni-odoo, if I'm not mistaken, we need to guide the user through configuring their webhooks now that we must listen to additional events. cc @auva-odoo

@nni-odoo nni-odoo force-pushed the master-xendit_tokenization-nni branch from 51d5030 to 8f88534 Compare June 18, 2024 08:00
@nni-odoo nni-odoo requested a review from auva-odoo June 18, 2024 08:00
@nni-odoo
Copy link
Contributor Author

Hello @auva-odoo thank you for the feedback on this!

@AntoineVDV actually, there's no additional config from Xendit dashboard with the newly added feature (or at least I'm not using it)

@AntoineVDV
Copy link
Collaborator

AntoineVDV commented Jun 18, 2024

@nni-odoo I enabled a bunch of them now, so it's hard to say for sure, but I think I had to enable at least these webhooks to receive feedback on card payments. Could you please double-check to make sure we don't miss anything?
image

@nni-odoo
Copy link
Contributor Author

@AntoineVDV I've retested again on runbot (https://64109170-master-all.runbot148.odoo.com/) and I've cleared all the webhook config except "Invoices paid", it is still able to carry out all the flows as expected!

@auva-odoo
Copy link
Contributor

Hey @nni-odoo I noticed this hasn't been merged yet. @AntoineVDV should it be rebased in 17.4 first?

@AntoineVDV
Copy link
Collaborator

Hi @auva-odoo 👋 Yes, this should should have been merged, same as for the upgrade PR @nni-odoo

Tokenization is introduced in odoo/odoo#158445 and needs extra configuration to setup for credit card payment.
We require optional 3DS to be enabled and dynamic 3DS to be disabled
@nni-odoo nni-odoo force-pushed the master-xendit_tokenization-nni branch from 8f88534 to 55f940d Compare July 18, 2024 07:04
@C3POdoo C3POdoo requested review from a team July 18, 2024 07:06
@nni-odoo nni-odoo changed the base branch from master to saas-17.4 July 18, 2024 07:18
@nni-odoo
Copy link
Contributor Author

apologies to those who got mentioned, I forgot to re-target the PR to 17.4 before rebasing it 😰

Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo pushed a commit that referenced this pull request Jul 18, 2024
Tokenization is introduced in odoo/odoo#158445 and needs extra configuration to setup for credit card payment.
We require optional 3DS to be enabled and dynamic 3DS to be disabled

closes #9394

Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
@robodoo robodoo closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants