-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[IMP] payment_xendit: tokenization #9394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @nni-odoo I suggested a small change to reflect the actual name of the page 🙂
Hello @nni-odoo, if I'm not mistaken, we need to guide the user through configuring their webhooks now that we must listen to additional events. cc @auva-odoo |
51d5030
to
8f88534
Compare
Hello @auva-odoo thank you for the feedback on this! @AntoineVDV actually, there's no additional config from Xendit dashboard with the newly added feature (or at least I'm not using it) |
@nni-odoo I enabled a bunch of them now, so it's hard to say for sure, but I think I had to enable at least these webhooks to receive feedback on card payments. Could you please double-check to make sure we don't miss anything? |
@AntoineVDV I've retested again on runbot (https://64109170-master-all.runbot148.odoo.com/) and I've cleared all the webhook config except "Invoices paid", it is still able to carry out all the flows as expected! |
Hey @nni-odoo I noticed this hasn't been merged yet. @AntoineVDV should it be rebased in 17.4 first? |
Hi @auva-odoo 👋 Yes, this should should have been merged, same as for the upgrade PR @nni-odoo |
Tokenization is introduced in odoo/odoo#158445 and needs extra configuration to setup for credit card payment. We require optional 3DS to be enabled and dynamic 3DS to be disabled
8f88534
to
55f940d
Compare
apologies to those who got mentioned, I forgot to re-target the PR to 17.4 before rebasing it 😰 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
Tokenization is introduced in odoo/odoo#158445 and needs extra configuration to setup for credit card payment. We require optional 3DS to be enabled and dynamic 3DS to be disabled closes #9394 Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
Tokenization is introduced in odoo/odoo#158445 and needs extra configuration to setup for credit card payment. We require optional 3DS to be enabled and dynamic 3DS to be disabled