Skip to content

Conversation

igbe-odoo
Copy link
Contributor

Add the modelo 130 report and the corresponding BOE files export for spain localization.

Add also some documentation for using the report.

task-3866238

@robodoo
Copy link
Collaborator

robodoo commented Jun 12, 2024

Pull request status dashboard

@igbe-odoo igbe-odoo force-pushed the 17.0-l10n_es-new-modelo-130-report-igbe branch 4 times, most recently from be5a847 to bf13403 Compare June 13, 2024 13:35
@igbe-odoo igbe-odoo changed the title [DRAFT][IMP]l10n_es: Tax report: Modelo 130 [IMP]l10n_es: Tax report: Modelo 130 Jun 20, 2024
@igbe-odoo igbe-odoo requested a review from malb-odoo June 20, 2024 07:39
@C3POdoo C3POdoo requested a review from a team June 20, 2024 07:39
@igbe-odoo igbe-odoo force-pushed the 17.0-l10n_es-new-modelo-130-report-igbe branch from bf13403 to dc6af30 Compare June 20, 2024 07:45
@toaa-odoo toaa-odoo force-pushed the 17.0-l10n_es-new-modelo-130-report-igbe branch from dc6af30 to bdcca7f Compare June 20, 2024 11:54
@toaa-odoo
Copy link
Contributor

Hi @igbe-odoo! Thanks for your great work. I pushed some changes to comply with documentation guidelines and removed some screenshots that were not necessary.

@odoo/be-doc-review From what I can tell, the R&D task has been not merged yet. Might be best to give r+ rights.

@toaa-odoo toaa-odoo requested a review from a team June 20, 2024 11:56
@auva-odoo auva-odoo force-pushed the 17.0-l10n_es-new-modelo-130-report-igbe branch from bdcca7f to f1c1b20 Compare June 21, 2024 09:55
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @igbe-odoo thank you for updating the doc 🙂 I also pushed some minor changes (to correct a typo and the formatting mainly). You can r+ whenever you're ready. Thanks again!
@robodoo delegate+

@igbe-odoo igbe-odoo force-pushed the 17.0-l10n_es-new-modelo-130-report-igbe branch 3 times, most recently from f4d0176 to fcbd2ac Compare June 27, 2024 07:28
@auva-odoo
Copy link
Contributor

Hey @igbe-odoo, I noticed that the (formatting) changes I pushed while reviewing this PR were overwritten and reverted. Just wanted to check in and see if there was a specific reason for that? Thanks!

@malb-odoo
Copy link
Contributor

i presume he forgot to pull the branch before force pushing on it 😬

@igbe-odoo
Copy link
Contributor Author

Indeed I made a little mistake while rebasing my branche I'm sorry about that I didn't see it, I will cherry pick your commit and reset the branch in the state she was before. Thanks you for noticing me the issue and please excuse my little mistake, mb on this :/

@auva-odoo
Copy link
Contributor

No worries at all, it happens! 🙂

@igbe-odoo igbe-odoo force-pushed the 17.0-l10n_es-new-modelo-130-report-igbe branch from fcbd2ac to d2d26ef Compare June 28, 2024 11:36
@igbe-odoo
Copy link
Contributor Author

It should be good now 😉

@igbe-odoo igbe-odoo force-pushed the 17.0-l10n_es-new-modelo-130-report-igbe branch 2 times, most recently from 56c2b66 to 145aefa Compare July 3, 2024 11:35
@malb-odoo malb-odoo requested a review from auva-odoo July 19, 2024 08:52
@malb-odoo
Copy link
Contributor

malb-odoo commented Jul 19, 2024

Don't know if the delegate still works with the different force push, can we have a new delegate if it's not the case 😄

Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay guys, for some reason I wasn't notified.
Anyways, @robodoo delegate+

@igbe-odoo igbe-odoo force-pushed the 17.0-l10n_es-new-modelo-130-report-igbe branch from 145aefa to d422aad Compare August 1, 2024 07:11
@igbe-odoo igbe-odoo force-pushed the 17.0-l10n_es-new-modelo-130-report-igbe branch from d422aad to cc71c1b Compare August 1, 2024 10:49
…o 130

Add the modelo 130 report and the corresponding BOE files export for spain localization.

As it's a brand-new report, we had to add it in a dedicated module.

task-3866238
@igbe-odoo igbe-odoo force-pushed the 17.0-l10n_es-new-modelo-130-report-igbe branch from cc71c1b to c70f766 Compare August 2, 2024 14:05
@william-andre
Copy link
Contributor

@igbe-odoo You have the delegated rights, so you have to r+ this one

@igbe-odoo
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit to odoo/odoo that referenced this pull request Aug 2, 2024
…o 130

Add the modelo 130 report and the corresponding BOE files export for spain localization.

As it's a brand-new report, we had to add it in a dedicated module.

task-3866238

closes #164946

Related: odoo/enterprise#62197
Related: odoo/documentation#9782
Signed-off-by: William André (wan) <wan@odoo.com>
@robodoo robodoo closed this in c9c5af7 Aug 2, 2024
Dasanchez1992 pushed a commit to Nosolotec/odoo that referenced this pull request Aug 22, 2024
…o 130

Add the modelo 130 report and the corresponding BOE files export for spain localization.

As it's a brand-new report, we had to add it in a dedicated module.

task-3866238

closes odoo#164946

Related: odoo/enterprise#62197
Related: odoo/documentation#9782
Signed-off-by: William André (wan) <wan@odoo.com>
riccardoSANEHO pushed a commit to resultrum/odoo that referenced this pull request Sep 30, 2024
…o 130

Add the modelo 130 report and the corresponding BOE files export for spain localization.

As it's a brand-new report, we had to add it in a dedicated module.

task-3866238

closes odoo#164946

Related: odoo/enterprise#62197
Related: odoo/documentation#9782
Signed-off-by: William André (wan) <wan@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants