-
Notifications
You must be signed in to change notification settings - Fork 10k
[IMP]l10n_es: Tax report: Modelo 130 #9782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
be5a847
to
bf13403
Compare
bf13403
to
dc6af30
Compare
dc6af30
to
bdcca7f
Compare
Hi @igbe-odoo! Thanks for your great work. I pushed some changes to comply with documentation guidelines and removed some screenshots that were not necessary. @odoo/be-doc-review From what I can tell, the R&D task has been not merged yet. Might be best to give r+ rights. |
bdcca7f
to
f1c1b20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @igbe-odoo thank you for updating the doc 🙂 I also pushed some minor changes (to correct a typo and the formatting mainly). You can r+ whenever you're ready. Thanks again!
@robodoo delegate+
f4d0176
to
fcbd2ac
Compare
Hey @igbe-odoo, I noticed that the (formatting) changes I pushed while reviewing this PR were overwritten and reverted. Just wanted to check in and see if there was a specific reason for that? Thanks! |
i presume he forgot to pull the branch before force pushing on it 😬 |
Indeed I made a little mistake while rebasing my branche I'm sorry about that I didn't see it, I will cherry pick your commit and reset the branch in the state she was before. Thanks you for noticing me the issue and please excuse my little mistake, mb on this :/ |
No worries at all, it happens! 🙂 |
fcbd2ac
to
d2d26ef
Compare
It should be good now 😉 |
56c2b66
to
145aefa
Compare
Don't know if the delegate still works with the different force push, can we have a new delegate if it's not the case 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay guys, for some reason I wasn't notified.
Anyways, @robodoo delegate+
145aefa
to
d422aad
Compare
d422aad
to
cc71c1b
Compare
…o 130 Add the modelo 130 report and the corresponding BOE files export for spain localization. As it's a brand-new report, we had to add it in a dedicated module. task-3866238
cc71c1b
to
c70f766
Compare
@igbe-odoo You have the delegated rights, so you have to r+ this one |
@robodoo r+ |
…o 130 Add the modelo 130 report and the corresponding BOE files export for spain localization. As it's a brand-new report, we had to add it in a dedicated module. task-3866238 closes #164946 Related: odoo/enterprise#62197 Related: odoo/documentation#9782 Signed-off-by: William André (wan) <wan@odoo.com>
…o 130 Add the modelo 130 report and the corresponding BOE files export for spain localization. As it's a brand-new report, we had to add it in a dedicated module. task-3866238 closes odoo#164946 Related: odoo/enterprise#62197 Related: odoo/documentation#9782 Signed-off-by: William André (wan) <wan@odoo.com>
…o 130 Add the modelo 130 report and the corresponding BOE files export for spain localization. As it's a brand-new report, we had to add it in a dedicated module. task-3866238 closes odoo#164946 Related: odoo/enterprise#62197 Related: odoo/documentation#9782 Signed-off-by: William André (wan) <wan@odoo.com>
Add the modelo 130 report and the corresponding BOE files export for spain localization.
Add also some documentation for using the report.
task-3866238