Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] Selection: Loop selection based on content #3663

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Feb 9, 2024

Similarly to the issue addressed in PR #3214, we want loopSelection to consider seemingly empty cells when considering the expansion zone.

This revision splits the behaviour of the selection processor for loopSelection and the other navigation features (like cluster jumping) as we still want to ignore cells with an empty evaluation in those cases. The reason being that the user could be lost if, when navigating with their keyboards, they end up with their selection on empty cell.

As for #3214, the fix will need to be adapted to account for the spreaded formulas.

Task: 3709340

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3573

@robodoo
Copy link
Collaborator

robodoo commented Feb 9, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Feb 9, 2024

@rrahir @LucasLefevre cherrypicking of pull request #3573 failed.

stdout:

Auto-merging src/selection_stream/selection_stream_processor.ts
Auto-merging tests/plugins/selection.test.ts
CONFLICT (content): Merge conflict in tests/plugins/selection.test.ts

stderr:

15:33:22.537869 git.c:463               trace: built-in: git cherry-pick c03cbf23db044566906c7d416826ed2b13d44552
error: could not apply c03cbf23d... [FIX] Selection: Loop selection based on content
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Similarly to the issue addressed in PR #3214, we want `loopSelection`
to consider seemingly empty cells when considering the expansion zone.

This revision splits the behaviour of the selection processor for
`loopSelection` and the other navigation features (like cluster
jumping) as we still want to ignore cells with an empty evaluation in
those cases. The reason being that the user could be lost if, when
navigating with their keyboards, they end up with their selection on
empty cell.

As for #3214, the fix will need to be adapted to account for the
spreaded formulas.

Task: 3709340
X-original-commit: 2a21fea
@rrahir rrahir force-pushed the saas-16.2-saas-16.1-emptycell-not-cellvalue-rar-Okp1-fw branch from d30b596 to 30a371d Compare February 9, 2024 16:58
@rrahir
Copy link
Collaborator

rrahir commented Feb 9, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Feb 9, 2024
Similarly to the issue addressed in PR #3214, we want `loopSelection`
to consider seemingly empty cells when considering the expansion zone.

This revision splits the behaviour of the selection processor for
`loopSelection` and the other navigation features (like cluster
jumping) as we still want to ignore cells with an empty evaluation in
those cases. The reason being that the user could be lost if, when
navigating with their keyboards, they end up with their selection on
empty cell.

As for #3214, the fix will need to be adapted to account for the
spreaded formulas.

closes #3663

Task: 3709340
X-original-commit: 2a21fea
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo closed this Feb 9, 2024
@fw-bot fw-bot deleted the saas-16.2-saas-16.1-emptycell-not-cellvalue-rar-Okp1-fw branch February 23, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants