[FW][FIX] Selection: Loop selection based on content #3667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similarly to the issue addressed in PR #3214, we want `loopSelection` to consider seemingly empty cells when considering the expansion zone. This revision splits the behaviour of the selection processor for `loopSelection` and the other navigation features (like cluster jumping) as we still want to ignore cells with an empty evaluation in those cases. The reason being that the user could be lost if, when navigating with their keyboards, they end up with their selection on empty cell. As for #3214, the fix will need to be adapted to account for the spreaded formulas. Task: 3709340 X-original-commit: 1a67085
|
@rrahir @LucasLefevre this PR targets saas-16.3 and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 9, 2024
Similarly to the issue addressed in PR #3214, we want `loopSelection` to consider seemingly empty cells when considering the expansion zone. This revision splits the behaviour of the selection processor for `loopSelection` and the other navigation features (like cluster jumping) as we still want to ignore cells with an empty evaluation in those cases. The reason being that the user could be lost if, when navigating with their keyboards, they end up with their selection on empty cell. As for #3214, the fix will need to be adapted to account for the spreaded formulas. closes #3667 Task: 3709340 X-original-commit: 1a67085 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
fw-bot
deleted the
saas-16.3-saas-16.1-emptycell-not-cellvalue-rar-AKcD-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to the issue addressed in PR #3214, we want
loopSelectionto consider seemingly empty cells when considering the expansion zone.This revision splits the behaviour of the selection processor for
loopSelectionand the other navigation features (like cluster jumping) as we still want to ignore cells with an empty evaluation in those cases. The reason being that the user could be lost if, when navigating with their keyboards, they end up with their selection on empty cell.As for #3214, the fix will need to be adapted to account for the spreaded formulas.
Task: 3709340
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist
Forward-Port-Of: #3663
Forward-Port-Of: #3573