Skip to content

[IMP] sale: auto-recalculate global discount on order line changes #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions discount_update/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import models
7 changes: 7 additions & 0 deletions discount_update/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
'name': "Discount Update",
'version': "1.0",
'depends': ["sale_management"],
'insallable': True,
'license': 'LGPL-3'
}
2 changes: 2 additions & 0 deletions discount_update/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from . import sale_order
from . import sale_order_line
38 changes: 38 additions & 0 deletions discount_update/models/sale_order.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
from odoo import fields, models


class SaleOrder(models.Model):
_inherit = "sale.order"

discount_percentage = fields.Float(string="Global Discount (%)")
wizard_ids = fields.One2many(
"sale.order.discount", "sale_order_id", string="Discount Wizards"
)

def _update_discount(self):

discount_product = self.env["product.product"].search([("name", "=", "Discount")], limit=1)
if not discount_product:
return

total_amount = sum(line.price_total for line in self.order_line if not line.is_discount_line())
if not total_amount:
discount_lines = self.order_line.filtered(lambda l: l.is_discount_line())
discount_lines.unlink()
return

if self.wizard_ids:
discount_percentage = self.wizard_ids[-1].discount_percentage
else:
return

discount_amount = total_amount * (discount_percentage)
discount_line = self.order_line.filtered(lambda l: l.is_discount_line())

if discount_line:
discount_line.write(
{
"price_unit": discount_amount * (-1),
"name": f"Discount{discount_percentage * 100:.2f}%",
}
)
31 changes: 31 additions & 0 deletions discount_update/models/sale_order_line.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
from odoo import api, models


class SaleOrderLine(models.Model):
_inherit = "sale.order.line"

def is_discount_line(self):
discount_product = self.order_id.env["product.product"].search([("name", "=", "Discount")], limit=1)
return self.product_id == discount_product

def unlink(self):
order_ids = self.mapped("order_id")
res = super().unlink()
for order in order_ids:
order._update_discount()
return res

@api.model_create_multi
def create(self, vals):
lines = super().create(vals)
for line in lines:
if line.order_id and not line.is_discount_line():
line.order_id._update_discount()
return lines

def write(self, vals):
res = super().write(vals)
for line in self:
if not line.is_discount_line():
line.order_id._update_discount()
return res